Conversation
github-actions
bot
added
the
dependencies
…oved from the definition in new SpiderMonkey version
…od on `JobQueue` for the new SpiderMonkey version
…ub hosted runners
test_bytes_instanceof: Python bytes instanceof JS Uint8Array assert False test_keys_iterator: TypeError iterator is not iterable If `explicit-resource-management` is enabled, the lib .so will be compiled differently to the header files when there's a `IF_EXPLICIT_RESOURCE_MANAGEMENT` macro used. The `enum JSProtoKey` index is off by 1 (header `JSProto_Uint8Array` 27 will be interpreted as `JSProto_Int8Array` in lib as lib has an extra element)
…ey were fixed in upstream SpiderMonkey See https://bugzilla.mozilla.org/show_bug.cgi?id=1751561 and https://bugzilla.mozilla.org/show_bug.cgi?id=1802675 See also: https://discourse.mozilla.org/t/problem-building-102-3-0esr-on-windows/105671
On https://searchfox.org/mozilla-central/rev/ead020d/mozglue/baseprofiler/public/BaseProfilerUtils.h#22, it detects Windows platform by seeing if the `XP_WIN` macro is defined, if not then assumes it's on POSIX and includes the `<unistd.h>` header to use `getpid()`. The `mozilla/BaseProfilerUtils.h` header file is introduced to `js/Debug.h` in https://phabricator.services.mozilla.com/D221102 (https://bugzilla.mozilla.org/show_bug.cgi?id=1911021), but it would be compiled without `XP_WIN` in our building configuration
Xmader
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changeset: https://hg.mozilla.org/mozilla-central/rev/250be4ca3c669db9a397456402f68249aa15d8d5