restore rounds check#25
Conversation
windymilla
left a comment
There was a problem hiding this comment.
The edit looks OK, but I am not able to test whether it works in that environment. @rtonsing - you can probably test it on your Linux system using command line arguments and verify that telling it to suppress proofer comments, for example, does not work without the edit, but does work with it.
|
I think I got confused when I went to try to set up a sandbox on TEST -- this is the standalone tool, only, not the one that is part of the ppwb? |
|
It is part of ppwb. Command line testing: now "regroup split wo-* *rds" works. I can run ppwb locally in Docker, but ppcomp always fails. |
When I looked at the ppcomp code in that repo, the code is ppcomp.py -- the ppwb version comes up as ppcomp.php when invoked from ppwb, which is why I questioned what I was supposed to be doing. I don't have a local ppcomp python environment set up for ppcomp (and would need to be led by the nose, because I'm not experienced enough setting up python environments to know what I'm doing). (Some things I can suss out by myself -- this one, I haven't yet.) |
|
ppwb runs ppcomp.php, which sets up command line options to pass to ppcomp.py. Can you duplicate the live ppwb to the sandbox, and just update ppcomp.py? |
|
Confirmed on test site that these work now:
|
|
Adding a very trivial change that was in my local code. |
Check for a file from rounds was previously removed, probably in error. So those options are not working.