Skip to content

restore rounds check#25

Merged
rtonsing merged 2 commits intoDistributedProofreaders:masterfrom
rtonsing:master
Feb 25, 2026
Merged

restore rounds check#25
rtonsing merged 2 commits intoDistributedProofreaders:masterfrom
rtonsing:master

Conversation

@rtonsing
Copy link
Collaborator

Check for a file from rounds was previously removed, probably in error. So those options are not working.

Copy link
Collaborator

@windymilla windymilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit looks OK, but I am not able to test whether it works in that environment. @rtonsing - you can probably test it on your Linux system using command line arguments and verify that telling it to suppress proofer comments, for example, does not work without the edit, but does work with it.

@srjfoo
Copy link
Member

srjfoo commented Feb 25, 2026

I think I got confused when I went to try to set up a sandbox on TEST -- this is the standalone tool, only, not the one that is part of the ppwb?

@rtonsing
Copy link
Collaborator Author

It is part of ppwb.

Command line testing: now "regroup split wo-* *rds" works.

I can run ppwb locally in Docker, but ppcomp always fails.

@srjfoo
Copy link
Member

srjfoo commented Feb 25, 2026

It is part of ppwb.

Command line testing: now "regroup split wo-* *rds" works.

I can run ppwb locally in Docker, but ppcomp always fails.

When I looked at the ppcomp code in that repo, the code is ppcomp.py -- the ppwb version comes up as ppcomp.php when invoked from ppwb, which is why I questioned what I was supposed to be doing. I don't have a local ppcomp python environment set up for ppcomp (and would need to be led by the nose, because I'm not experienced enough setting up python environments to know what I'm doing). (Some things I can suss out by myself -- this one, I haven't yet.)

@rtonsing
Copy link
Collaborator Author

ppwb runs ppcomp.php, which sets up command line options to pass to ppcomp.py.

Can you duplicate the live ppwb to the sandbox, and just update ppcomp.py?

@rtonsing
Copy link
Collaborator Author

Confirmed on test site that these work now:

  • remove [**proofreaders notes]
  • regroup split wo-* *rds

@rtonsing
Copy link
Collaborator Author

Adding a very trivial change that was in my local code.

@rtonsing rtonsing merged commit f7651f0 into DistributedProofreaders:master Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants