Improve Scanno regex & fix bug in S/R replacement#1740
Merged
windymilla merged 1 commit intoDistributedProofreaders:masterfrom Feb 24, 2026
Merged
Improve Scanno regex & fix bug in S/R replacement#1740windymilla merged 1 commit intoDistributedProofreaders:masterfrom
windymilla merged 1 commit intoDistributedProofreaders:masterfrom
Conversation
If regex had nested lookahead/lookbehind at the end of the string, the code failed to remove it properly, so the replacement didn't work. Also, stealth scanno regexes 18 & 19 were wrong - they matched the correct string, but didn't fix them correctly. And the original purpose of the work - regex 18 now doesn't match if the line below is actually lowercase markup for poetry, center, etc., e.g. `p/`
Collaborator
Author
|
Testing notes: Example file:
|
srjfoo
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If regex had nested lookahead/lookbehind at the end of the string, the code failed to remove it properly, so the replacement didn't work.
Also, stealth scanno regexes 18 & 19 were wrong - they matched the correct string, but didn't fix them correctly.
And the original purpose of the work - regex 18 now doesn't match if the line below is actually lowercase markup for poetry, center, etc., e.g.
p/