Skip to content

Delete page-related events records #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 1 commit into from
Apr 22, 2026
Merged

Delete page-related events records #1577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions tools/project_manager/page_operations.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,29 @@ function page_del($projectid, $image)
return _("There is no page with that imagename.");
}

// Delete related page records from events tables.
// Note that we don't delete the page_events records to retain the fact
// that this page at one point existed and had operations done against it.
// Indeed, the delete operation below will add a delete event_type.
foreach (["wordcheck_events", "format_preview_events"] as $table_name) {
$query = sprintf(
"
DELETE FROM %s
WHERE projectid = '%s' AND image = '%s'
",
$table_name,
DPDatabase::escape($projectid),
DPDatabase::escape($image)
);
DPDatabase::query($query);
}

global $pguser;
Page_delete($projectid, $image, $pguser);

// Delete the image file from the project directory.
global $projects_dir;
$image_path = "$projects_dir/$projectid/$image";
$project = new Project($projectid);
$image_path = "$project->dir/$image";
if (! unlink($image_path)) {
return sprintf(_('Unable to remove file %s'), $image_path);
}
Expand Down