Skip to content

WordCheck highlights all uncommon script characters when all languages are deselected #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 3 commits into from
Feb 21, 2026
Merged

WordCheck highlights all uncommon script characters when all languages are deselected #1565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e846f9
in WordCheck, if no langs specified, suppress all input boxes to high…
Mrducky Feb 19, 2026
aa5967e
Add comment about showing uncommon script highlighting for all the text
Mrducky Feb 21, 2026
7349a03
fix linting error
Mrducky Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tools/proofers/spellcheck_text.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,14 @@ function spellcheck_text($orig_text, $projectid, $imagefile, $languages, $accept
// prepare the text for checking, in this case change all EOLs to spaces
$orig_text = str_replace('[lf]', ' ', $orig_text);

[$badWordHash, $languages, $messages] =
get_bad_word_levels_for_project_text($orig_text, $projectid, $languages, $accepted_words);
// If the user deselected all languages, then fully suppress all bad words in order to
// suppress all input boxes so that uncommon script highlighting covers the entire text.
if (!empty($languages)) {
[$badWordHash, $languages, $messages] =
get_bad_word_levels_for_project_text($orig_text, $projectid, $languages, $accepted_words);
} else {
[$badWordHash, $languages, $messages] = [[], [], []];
}

[$uncommonScriptWords, $uncommonScripts] =
get_words_with_uncommon_scripts(array_keys(get_distinct_words_in_text($orig_text)));
Expand Down