Skip to content

Feat/test#835

Open
nafsonig wants to merge 12 commits into
DistinctCodes:mainfrom
nafsonig:feat/test
Open

Feat/test#835
nafsonig wants to merge 12 commits into
DistinctCodes:mainfrom
nafsonig:feat/test

Conversation

@nafsonig
Copy link
Copy Markdown
Contributor

Update Completed

  • Created multisig_tests.rs
  • Updated tests.rs to include the new suite

What’s covered

  • initialize() verified with correct threshold and duplicate init failure
  • submit_transaction() success path and non-owner submission failure
  • confirm_transaction() approval accumulation and duplicate owner approval rejection
  • execute_transaction() fails below threshold, succeeds at threshold, and rejects re-execution
  • revoke_confirmation() lowers the approval count and blocks execution after revocation
  • propose_add_owner() / propose_remove_owner() checks non-owner rejection and owner removal constraints
  • 2-of-3 and 3-of-5 threshold flows both tested

Verification

  • Editor diagnostics report no errors in:
    • multisig_tests.rs
    • tests.rs

Run cargo test -p multisig-wallet in contracts to validate the suite fully.

Updated todo list

Made changes.

Closes #816
Closes #822

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@nafsonig is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 30, 2026

@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Copy link
Copy Markdown
Collaborator

@yusuftomilola yusuftomilola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My boss. Kindly help resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants