Feat/test#835
Open
nafsonig wants to merge 12 commits into
Open
Conversation
|
@nafsonig is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
requested changes
May 31, 2026
Collaborator
yusuftomilola
left a comment
There was a problem hiding this comment.
My boss. Kindly help resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Completed
What’s covered
initialize()verified with correct threshold and duplicate init failuresubmit_transaction()success path and non-owner submission failureconfirm_transaction()approval accumulation and duplicate owner approval rejectionexecute_transaction()fails below threshold, succeeds at threshold, and rejects re-executionrevoke_confirmation()lowers the approval count and blocks execution after revocationpropose_add_owner()/propose_remove_owner()checks non-owner rejection and owner removal constraints2-of-3and3-of-5threshold flows both testedVerification
Updated todo list
Made changes.
Closes #816
Closes #822