Conversation
|
The change in principle looks fine, but it failed the formatting. Inspired by this, I pushed proper documentation and automation for running all the auto-formatters before push. Can you have a try? |
|
Actually, I just realized that DAP is enabled in the code you pushed, so all the CI runners are waiting for the debugger to connect now. Can you comment that out for now? I am becoming more convinced that that API should actually be an env variable, so we can add it to our command-lines but CI will never have to deal with it (accidentally at least). |
|
Cool, thanks. Can you also merge with The CI format checks are still failing, and that script will just make it go away 99% of the time. |
A few changes in configs and imports