RS-19913: Fix variable name sanitization logic #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinCCYap
changed the title
JustinCCYap
commented
Nov 5, 2025
Contributor
Author
There was a problem hiding this comment.
The changes in this file fix an existing fail in the unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidied up the logic and added an extra step to ensure that variable names only begin with valid characters. We no longer throw warnings as any invalid names would have been created by us and not from the user. The names in the input data sets should already be valid.
See this link for the variable name rules: https://www.ibm.com/docs/en/spss-statistics/cd?topic=view-variable-names