Draft
Conversation
….json - Updated addRelationToRelationsJson to accept relationTripletId parameter - Added utility functions getRelationById and findRelationTripletId to typeUtils - Updated all callers to find the relation triplet id before creating relations: - DiscourseRelationShape.tsx: Added node type resolution and triplet lookup - RelationshipSection.tsx: Updated add/delete operations to use triplet id - RelationPanel.tsx: Updated relation creation and grouping logic - Fixed migration function to use relation triplet id when migrating from frontmatter - Updated relation filtering logic to work with triplet ids instead of type ids This ensures that RelationInstance.type stores the relation triplet id (DiscourseRelation.id with rel3_ prefix) instead of the relation type id (DiscourseRelationType.id). Co-authored-by: Trang Doan <trangdoan982@users.noreply.github.com>
Changed relationTypeId to relationTripletId to match the updated function signature. Co-authored-by: Trang Doan <trangdoan982@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
typefield inrelations.jsonto use the relation triplet ID instead of the relation type ID.Previously, relations were stored using the generic
relationTypeId(e.g.,rel_...), which is not unique for specific subject-predicate-object combinations. This PR updates the storage and all related logic to use the uniquerelation triplet id(e.g.,rel3_...), ensuring each relation instance is correctly identified.Linear Issue: ENG-1423