Skip to content

[ENG-1394] Fix "folder already exists" bug #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trangdoan982 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ENG-1394] Fix "folder already exists" bug #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions apps/obsidian/src/utils/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
import { TAbstractFile, TFolder, Vault, normalizePath } from "obsidian";
import { Vault, normalizePath } from "obsidian";

export const checkAndCreateFolder = async (folderpath: string, vault: Vault) => {
export const checkAndCreateFolder = async (
folderpath: string,
vault: Vault,
) => {
if (!folderpath) return;
const normalizedPath = normalizePath(folderpath);

const abstractItem = vault.getAbstractFileByPath(normalizedPath);
if (abstractItem instanceof TFolder) return;
if (abstractItem instanceof TAbstractFile) {
throw new Error(`${normalizedPath} exists as a file`);
const existingFolder = await vault.adapter.exists(normalizedPath, false);
if (existingFolder) return;

try {
await vault.createFolder(normalizedPath);
} catch (e) {
const message = e instanceof Error ? e.message : String(e);
if (
message.includes("Folder already exists") ||
message.includes("already exists")
) {
return;
}
throw e;
}
await vault.createFolder(normalizedPath);
};

export const getNewUniqueFilepath = ({
Expand Down