ENG-839: Guard incomplete relation types in canvas#1095
Open
trangdoan982 wants to merge 4 commits into
Open
Conversation
Prevent crashes and confusing warnings when relation definitions are missing required fields, and guide users to settings to fix relation configuration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Referenced node tools are keyed by action names, not relation labels, so the incomplete-relation check never ran there. Co-authored-by: Cursor <cursoragent@cursor.com>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Skip relations with "?" source/destination/complement values so the dropdown matches relation tool validation. Co-authored-by: Cursor <cursoragent@cursor.com>
mdroidian
approved these changes
May 28, 2026
Member
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Let's either
- change where we set
"?"to""and double check that doesn't break anything (then remove the"?"check
or
- Write this check in one place DRY, so that when we do remove the
"?"in the future that we don't need to change it in multiple places
Also, I don't think relation.complement is ever set to "?"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/3977b131b059477595abae91916662f8
Summary
Test plan
Made with Cursor