ENG-1793 Roam sync does not recover from Concept upsert failure#1075
Open
maparent wants to merge 4 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
changed the base branch from
main
to
eng-1791-obsidian-sync-does-not-recover-from-concept-upsert-failure
maparent
force-pushed
the
eng-1791-obsidian-sync-does-not-recover-from-concept-upsert-failure
branch
from
699aa2f to
fb2fc57
Compare
maparent
force-pushed
the
eng-1793-roam-sync-does-not-recover-from-concept-upsert-failure
branch
from
4e5c768 to
64e405f
Compare
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 673d338230
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
maparent
force-pushed
the
eng-1793-roam-sync-does-not-recover-from-concept-upsert-failure
branch
2 times, most recently
from
eb77cdc to
2a83952
Compare
… Refactoring: Avoid conversions by passing timestamps to nodeTypeSince, getAllDiscourseNodesSince, convertDgToSupabaseConcepts.
maparent
force-pushed
the
eng-1793-roam-sync-does-not-recover-from-concept-upsert-failure
branch
from
2a83952 to
6e814d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1793/roam-sync-does-not-recover-from-concept-upsert-failure
https://www.loom.com/share/9cf9602e2c2e4ac1a449055b6e36917b
ETA after loom: undefined was never actually sent to the getAllMissingOrNewDiscourseNodes, which would affect first-ever upload. Corrected. Had some downstream impact, had to make sure getAllDiscourseNodesSince could handle undefined; refactored ISO string to ms number.