ENG-1731: Add keyboard-only filtering with tag chips#1072
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 620c204db8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
A few things I noticed with this PR that I think we should address:
Input box alignment
It looks like this PR introduces a misalignment of the search box with the icons. I would consider this a regression that needs to be fixed:
Not using Blueprint Tags
Did we try using Blueprint Tag, TagInput, or InputGroup for this? Were there some issues stopping us from using the components that Roam style guide recommends?
Tailwind
As discussed in our last meeting, we noting how Roam doesn't handle all of the tailwind class syntax: specifically arbitrary values. So let's do a quick run through to double check.
|
Addressed in 542ac30:
|
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
Replace the advanced search input with a chip-based type filter input that supports ghost tab-completion and keyboard chip navigation while staying in sync with the dropdown filter state. Co-authored-by: Cursor <cursoragent@cursor.com>
Use Tag with getNodeTagStyles for filter chips while keeping a custom input for ghost Tab completion. Fix header alignment, Roam-safe styling, remove unnecessary memos, and guard ArrowDown when there are no results. Co-authored-by: Cursor <cursoragent@cursor.com>
trangdoan982
force-pushed
the
eng-1731-add-keyboard-only-filtering-with-tag-chips
branch
from
6f8193b to
afe9ade
Compare
…handler. Use Tailwind flex-1 instead of inline flex styles, rely on Blueprint Tag active state for chip focus, document Tag vs TagInput choice, pass a single onSearchKeyDown prop, and restore fixed-height toolbar for filter controls. Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
https://www.loom.com/share/dd5b9491a87b436395a5fb2344b51c24
Summary
Tabcommit behavior (prefix-only) and chip keyboard navigation/removalTest plan
Tabto commit a ghost completion into a chip and confirm search term clearsMade with Cursor