Skip to content

User management fields #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brady-lamansky-gtt wants to merge 7 commits into
base: develop
Choose a base branch
from
+123 −61
Open

User management fields #2921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7cdfc18
Removed unused Health Metrics js
jlamanskygitt Jan 22, 2026
a7d765c
Merge branch 'DiscipleTools:develop' into develop
jlamanskygitt Feb 9, 2026
80b8f75
Merge branch 'DiscipleTools:develop' into develop
jlamanskygitt Feb 18, 2026
7410e4a
replaced user management fields w/ dt web components
brady-lamansky-gtt May 21, 2026
788fb0e
Merge branch 'develop' into user-management-fields
brady-lamansky-gtt May 21, 2026
d835dff
fixed lint
brady-lamansky-gtt May 21, 2026
86b423a
fixed gender display
brady-lamansky-gtt May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dt-core/utilities/dt-components.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public static function shared_attributes( $field_key, $fields, $post, $params =
$shared_attributes = '
id="' . esc_attr( $display_field_id ) . '"
name="' . esc_attr( $field_key ) . '"
placeholder="' . esc_attr( $params['placeholder'] ?? '' ) . '"
' . $class . '
' . $label_attr . '
' . esc_html( $post_type ?? '' ) . '
Expand Down
112 changes: 79 additions & 33 deletions dt-users/template-new-user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,48 @@
</dl>
<div id="contact-result"></div>
<dl>
<dt><label for="eman"><?php esc_html_e( 'Display Name', 'disciple_tools' ); ?></label></dt>
<dd><input type="text" class="input" id="eman" placeholder="<?php esc_html_e( 'Nickname (Display Name)', 'disciple_tools' ); ?>" required autocomplete="off" /> </dd>
<dt><label for="liame"><?php esc_html_e( 'Email', 'disciple_tools' ); ?></label></dt>
<dd><input type="email" class="input" id="liame" placeholder="<?php esc_html_e( 'Email', 'disciple_tools' ); ?>" required autocomplete="off" /> </dd>
<dt></dt>
<dd>
Comment on lines 113 to +115
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this dl/dt/dd structure. A dl is a definition list for definition terms (dt) and descriptions (dd). It works well for labels and values, but those are contained within the components now. We can just put the components side-by-side (except maybe the hidden ones, which can stay in their own div).

<?php DT_Components::render_text( 'nickname', [
'nickname' => [
'name' => __( 'Display Name', 'disciple_tools' ),
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => 'Nickname (Display Name)' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value needs to be localized so it's translated in other languages

</dd>
<dt></dt>
<dd>
<?php DT_Components::render_text( 'email', [
'email' => [
'name' => __( 'Email', 'disciple_tools' ),
'type' => 'text',
'default' => '',
'required' => true,
]
], [], [ 'placeholder' => 'Email' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize placeholder

</dd>
<div class="hidden-fields" style="display:none">
<dt><label for="emanresu"><?php esc_html_e( 'Username', 'disciple_tools' ); ?></label></dt>
<dd><input type="text" class="input" id="emanresu" placeholder="<?php esc_html_e( 'Username', 'disciple_tools' ); ?>" autocomplete="off" /> </dd>
<dt><label for="drowssap"><?php esc_html_e( 'Password', 'disciple_tools' ); ?></label></dt>
<dd><input type="password" class="input" id="drowssap" placeholder="<?php esc_html_e( 'Password', 'disciple_tools' ); ?>" autocomplete="off" /> </dd>
<dt></dt>
<dd>
<?php DT_Components::render_text( 'username', [
'username' => [
'name' => __( 'Username', 'disciple_tools' ),
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => 'Username' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize placeholder

</dd>
<dt></dt>
<dd>
<?php DT_Components::render_text( 'password', [
'password' => [
'name' => __( 'Password', 'disciple_tools' ),
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => 'Password' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize placeholder

</dd>
</div>
<?php if ( $current_user_can_manage_users ) : ?>
<div id="show-shield-banner" style="text-align: center; background-color:rgb(236, 245, 252);margin: 3px -15px 15px -15px;">
Expand Down Expand Up @@ -175,23 +208,36 @@

<div id="optional-fields" class="cell medium-6 show-for-medium">
<dl>
<dt><label for="first_name"><?php esc_html_e( 'First Name', 'disciple_tools' )?> (<?php esc_html_e( 'optional', 'disciple_tools' )?>)</label></dt>
<dd><input class="input" type="text" class="input" id="first_name" data-optional
name="first_name" placeholder="<?php esc_html_e( 'First Name', 'disciple_tools' )?>" />
<dt></dt>
<dd>
<?php DT_Components::render_text( 'first_name', [
'first_name' => [
'name' => __( 'First Name (optional)', 'disciple_tools' ),
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => 'First Name' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize placeholder

</dd>
<dt><label for="last_name"><?php esc_html_e( 'Last Name', 'disciple_tools' )?> (<?php esc_html_e( 'optional', 'disciple_tools' )?>)</label></dt>
<dd><input class="input" type="text" class="input" id="last_name" data-optional name="last_name" placeholder="<?php esc_html_e( 'Last Name', 'disciple_tools' )?>"/></dd>
<dt><label for="gender">
<?php esc_html_e( 'Gender', 'disciple_tools' ) ?> (<?php esc_html_e( 'optional', 'disciple_tools' )?>)
</label></dt>
<dt></dt>
<dd>
<select class="select-field" id="gender" style="width:auto; display: block" data-optional>
<?php foreach ( $gender_fields['default'] as $option_key => $option_value ): ?>
<option value="<?php echo esc_html( $option_key )?>">
<?php echo esc_html( $option_value['label'] ) ?>
</option>
<?php endforeach; ?>
</select>
<?php DT_Components::render_text( 'last_name', [
'last_name' => [
'name' => __( 'Last Name (optional)', 'disciple_tools' ),
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => 'Last Name' ] ) ?>
Copy link
Copy Markdown
Collaborator

@cairocoder01 cairocoder01 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize placeholder

</dd>
<dt></dt>
<dd>
<?php DT_Components::render_key_select( 'gender', [
'gender' => [
'name' => __( 'Gender (optional)', 'disciple_tools' ),
'type' => 'key_select',
'default' => $gender_fields['default'],
'select_cannot_be_empty' => true,
]
], [ 'gender' => [ 'key' => 'male' ] ], [] ) ?>
</dd>

<?php // site defined fields
Expand All @@ -201,23 +247,23 @@
}
?>
<dt>
<label for="<?php echo esc_attr( $dt_field['key'] ) ?>"><?php echo esc_html( $dt_field['label'] ) ?> (<?php esc_html_e( 'optional', 'disciple_tools' )?>)</label>
</dt>
<dd><input type="text"
data-optional
class="input"
id="<?php echo esc_attr( $dt_field['key'] ) ?>"
name="<?php echo esc_attr( $dt_field['key'] ) ?>"
placeholder="<?php echo esc_html( $dt_field['label'] ) ?>"
value=""/>
<dd>
<?php DT_Components::render_text( $dt_field['key'], [
$dt_field['key'] => [
'name' => $dt_field['label'],
'type' => 'text',
'default' => '',
]
], [], [ 'placeholder' => $dt_field['label'], 'data-optional' => true ] ) ?>
</dd>
<?php
} // end foreach
?>

<dt><label for="description"><?php esc_html_e( 'Biography', 'disciple_tools' )?> (<?php esc_html_e( 'optional', 'disciple_tools' )?>)</label></dt>
<dd><textarea
type="text" class="input" id="description"
<dd><dt-textarea
class="input" id="description"
name="description"
placeholder="<?php esc_html_e( 'Biography', 'disciple_tools' )?>"
rows="5"
Expand Down
Loading
Loading