-
Notifications
You must be signed in to change notification settings - Fork 66
#2895 - Bulk Edit - User Select Typeahead #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
corsacca
merged 9 commits into
DiscipleTools:develop
from
kodinkat:2895-bulk-edit-user-select-typeahead
Mar 23, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
896294f
Refactor user_select handling in modular-list-bulk.js and shared-func…
kodinkat c631219
Enhance user_select handling in modular-list-bulk.js
kodinkat cb36761
Enhance user ID handling in modular-list-bulk.js
kodinkat 619e2ac
Refactor user selection normalization in modular-list-bulk.js
kodinkat cb26e2d
Merge branch 'develop' of https://github.com/DiscipleTools/disciple-t…
kodinkat b546e99
Remove unused bulk edit field handler initialization in modular-list-…
kodinkat 0c52ffc
Merge branch 'develop' into 2895-bulk-edit-user-select-typeahead
corsacca 108f582
Simplify
corsacca 58905e2
npm run build
corsacca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,33 @@ | ||
| import { E as s, C as e, w as D, B as o, D as i, a as l, b as n, d as r, e as c, f as u, u as p, A as C, g as M, x as T, h as m, i as x, j as S, y as g, k as B, t as d, r as h, l as v, m as A, n as L, o as b, p as f, z as y, q as F, c as j, v as k } from "./index-B5P35fmQ.js"; | ||
| import { E as e, C as s, x as D, B as o, D as l, a as i, b as n, d as r, e as c, f as p, u, w as C, A as M, g as T, h as m, i as x, j as S, y as d, k as g, t as B, r as h, l as v, m as A, n as b, o as F, p as L, z as f, q as y, c as U, v as j } from "./index-DpLFOrwQ.js"; | ||
| export { | ||
| s as ApiService, | ||
| e as ComponentService, | ||
| e as ApiService, | ||
| s as ComponentService, | ||
| D as DtAlert, | ||
| o as DtBase, | ||
| i as DtButton, | ||
| l as DtChurchHealthCircle, | ||
| l as DtButton, | ||
| i as DtChurchHealthCircle, | ||
| n as DtConnection, | ||
| r as DtCopyText, | ||
| c as DtDate, | ||
| u as DtDatetime, | ||
| p as DtFormBase, | ||
| C as DtIcon, | ||
| M as DtLabel, | ||
| T as DtList, | ||
| p as DtDatetime, | ||
| u as DtFileUpload, | ||
| C as DtFormBase, | ||
| M as DtIcon, | ||
| T as DtLabel, | ||
| m as DtLocation, | ||
| x as DtLocationMap, | ||
| S as DtMapModal, | ||
| g as DtModal, | ||
| B as DtMultiSelect, | ||
| d as DtMultiSelectButtonGroup, | ||
| d as DtModal, | ||
| g as DtMultiSelect, | ||
| B as DtMultiSelectButtonGroup, | ||
| h as DtMultiText, | ||
| v as DtNumberField, | ||
| A as DtSingleSelect, | ||
| L as DtTags, | ||
| b as DtText, | ||
| f as DtTextArea, | ||
| y as DtTile, | ||
| F as DtToggle, | ||
| j as DtUsersConnection, | ||
| k as version | ||
| b as DtTags, | ||
| F as DtText, | ||
| L as DtTextArea, | ||
| f as DtTile, | ||
| y as DtToggle, | ||
| U as DtUsersConnection, | ||
| j as version | ||
| }; |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kodinkat this looks like a whole lot of code handling maybes.
Can we double check the actual values being passed arround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kodinkat, my question still stands. Why handle every single possible value, instead of pulling from what the component actually returns?