Add missing french translations for at least toot toast publications#2465
Open
pylapp wants to merge 1 commit into
Open
Add missing french translations for at least toot toast publications#2465pylapp wants to merge 1 commit into
pylapp wants to merge 1 commit into
Conversation
…Dimillian#2430) Some translations were missing in french. It implied some issues for example in the bug Dimillian#2430, where toast of publications status were not translated and wordking key displayed instead. In addition, for notifications pane, two wordings were hard-coded in english. Thus two new entries have been added in the localizables file. Translations have been brought for english and french. For other languages, to preven the display of the wording key and keep the english wording displayed, the english wordings have been copied. Related to Dimillian#2430 Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
Contributor
Author
|
@Dimillian The pull request is ready for review 🤘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some translations were missing in french.
It implied some issues for example in the bug #2430, where toast of publications status were not translated and wordking key displayed instead.
In addition, for notifications pane, two wordings were hard-coded in english.
Thus two new entries have been added in the localizables file.
Translations have been brought for english and french.
For other languages, to preven the display of the wording key and keep the english wording displayed, the english wordings have been copied.
Now all french wordings are ok (no missing, all reviewed).