Feat: Add PHPStorm to the IDE selection and add CSS to stretch out command output block to full width for larger screens#566
Conversation
…ut is vertically cut off at half of the screen. This fixes it so that it spans the whole content area to see the full output
…onitors it gets cut off when there's extra space
…and then enabling the IDE. We'll use the same pattern the author intended
aolin480
force-pushed
the
feature/phpstorm-ide
branch
from
732ea00 to
387f0b9
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 732ea00003
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aolin480
left a comment
aolin480
left a comment
There was a problem hiding this comment.
2 Codex issues have been patched
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d84967779
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07320349d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97969f40cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5035fdeb31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d372eed1e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 742857ca1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 363d2fac8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18b2755172
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .iter() | ||
| .position(|target| target.get("id").and_then(Value::as_str) == Some("finder")) | ||
| .unwrap_or(existing_targets.len()); | ||
|
|
||
| existing_targets.insert(insert_at, phpstorm_target); |
There was a problem hiding this comment.
read_settings() runs migrate_open_app_targets() on every launch, and this insertion fires whenever the saved openAppTargets array lacks phpstorm. Removing built-in targets is already a supported/persisted user action in src/features/settings/hooks/useSettingsOpenAppDrafts.ts:103-115, so after upgrading, anyone who deletes PhpStorm from Settings will have it silently re-added the next time the app restarts. This needs a one-time/versioned migration; otherwise the new target can never stay removed.
Useful? React with 👍 / 👎.
| if is_phpstorm_app_identifier(&normalized) { | ||
| return Some("phpstorm"); |
There was a problem hiding this comment.
For macOS file links with a line/column, every recognized PhpStorm app name/path is collapsed to the global phpstorm launcher here, and open_workspace_in_core() then prefers that CLI (io.rs:265-273) over open -a <configured app>. Because the app name field is user-editable in Settings (src/features/settings/components/sections/SettingsOpenAppsSection.tsx:111-126), users who point it at a specific PhpStorm.app bundle (for example a non-default install or a second build) will still open whichever installation the PATH launcher targets, not the one they selected.
Useful? React with 👍 / 👎.
|
FYI you know you can add any apps from the settings? :) |
NOOOO!!! Are you serious?! LMAO Alright, well. This PR was fun. lol I'll close it. Thanks @Dimillian |
2 participants
synopsis.
I was bummed PHPStorm wasn't in the Codex Desktop app where as CodexMonitor may be open to it, so I added it as an IDE option to the IDE list. It should be cross platform compatible with macOS, Windows, and Linux. I have been running this version for a few days now and it has been working great in macOS, but haven't tried it in Windows or Linux yet.
Also, I noticed that when Codex runs a command, the command output was chopped off 75% of the way, and on larger monitors, if we can see more of that command it would be better, so I added CSS to stretch that out full width as well.
validation.
npm run typecheckcd src-tauri && cargo checkcd src-tauri && cargo test symphony_core --lib