fix(web3-providers): remove duplicate 'collect' and add missing 'borrow' in LiquidityOut type#12371
Open
stringsbuilder wants to merge 1 commit intoDimensionDev:developfrom
Open
fix(web3-providers): remove duplicate 'collect' and add missing 'borrow' in LiquidityOut type#12371stringsbuilder wants to merge 1 commit intoDimensionDev:developfrom
stringsbuilder wants to merge 1 commit intoDimensionDev:developfrom
Conversation
…ow' in LiquidityOut type Signed-off-by: stringsbuilder <stringsbuilder@outlook.com>
Jack-Works
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The LiquidityOut type had 'collect' listed twice, which is redundant in TypeScript union types.
According to the comment above indicating "Aave like actions: supply, withdraw, borrow, repay", the 'borrow' action was missing from the LiquidityOut type definition.
This fix removes the duplicate 'collect' and adds the missing 'borrow' action to properly represent all Aave liquidity output operations.
Type of change
Previews
Checklist
console.logsIf this PR depends on external APIs:
chrome-extension://[id]moz-extension://[id]