Fix/rounding error payouts#232
Closed
whitezaddy wants to merge 3 commits into
Closed
Conversation
whitezaddy
force-pushed
the
fix/rounding-error-payouts
branch
from
09cea67 to
af62a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #169
Title: Fix: Rounding Error in Reward Payouts (Dust Accumulation)
Internal Ref: #CO-169 Labels: contracts, stellar-wave, complexity-medium
📝 Summary
This PR addresses an audit finding where the contracts were accumulating "dust" over time due to fractional rounding errors during the settlement reward distribution. The previous implementation tracked remainders (rewardDust) improperly, leading to stranded bounty tokens in the contract.
The reward payout logic has been redesigned to precisely track the cumulative claimedWinnerWeightedStake and distributedRewards. The final participant to claim rewards now receives the exact remaining token balance (totalRewards - distributedRewards), ensuring 100% distribution of rewards and zero dust accumulation.
🛠️ Technical Changes
[TruthBountyWeighted.sol](code-assist-path:c:\Users\user\Desktop\Drips Wave Projects\truthbounty-contract\contracts\TruthBountyWeighted.sol) & [TruthBounty.sol](code-assist-path:c:\Users\user\Desktop\Drips Wave Projects\truthbounty-contract\contracts\TruthBounty.sol):
Replaced rewardDust and rewardsDistributedCount with claimedWinnerWeightedStake (or claimedWinnerStake) and distributedRewards.
Updated claimSettlementRewards to identify the last claimant and grant them the exact mathematical remainder.
Test Suite Enhancements:
Added Fuzz Testing: Created RoundingErrorPrevention.fuzz.sol which simulates 256 randomized claim scenarios to strictly verify that distributedRewards == totalRewards with 0 dust remaining.
Added Invariant Testing: Created RewardRoundingInvariant.t.sol to formally verify that the protocol's distributed rewards never exceed the total rewards and exactly match at full claim.
Testing Maintenance: Cleaned up several stale test files, resolved shadowing variables, fixed calldata/memory array bound issues in the fuzzer, and disabled SMTChecker in [foundry.toml](code-assist-path:c:\Users\user\Desktop\Drips Wave Projects\truthbounty-contract\foundry.toml) to suppress noisy environment warnings.
✅ Acceptance Criteria Met
[x] Implementation needed is functional (Rounding error tracked properly).
[x] Tests passed (Forge test suite compiles and succeeds).
[x] Verify with protocol invariants (Invariant handlers verified).
[x] No regressions (Backward compatibility with equal-weight fallback and standard staking is intact).
🧪 How to Test
Execute the test suite using Foundry:
forge test --match-contract RoundingErrorPreventionFuzzTest
forge test --match-contract RewardRoundingInvariantTest