closes #164: fix: implement missing event emissions and resolve contract compilation issues#208
Merged
Merged
Conversation
Contributor
|
@mansur-codes resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves audit issue #164 by ensuring the
StakeWithdrawnevent is systematically emitted during all partial (loser) and full (winner) stake return flows. Additionally, it resolves outstanding repository compilation issues, UUPS authorization abstractions, and test suite TypeScript type alignment errors.Type of Change
Related Issue
Closes #164
Changes Made
1. Staking Event Coverage & Variable Cleanup
StakeWithdrawnevent emissions inside bothwithdrawSettledStakeandclaimSettlementRewardsto guarantee complete ledger visibility for off-chain indexers.slashAmountinsidewithdrawSettledStaketo clear compiler warnings.2. Core Compilation & Governance Alignment
_authorizeUpgradesequence forTruthBountyTokento satisfy abstract UUPS interfaces.virtual/override) and unified custom error matching to clean up inheritance faults.3. Test Suite Modernization
BigInttype-casting) and dynamic block-timestamp drift handling.StakeWithdrawnpartial and full event emissions.Testing
How has this been tested?