fix: enforce aggregation confidence floor minimum#255
Merged
dDevAhmed merged 2 commits intoMay 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Closes #212, Closes #211
Implemented protocol-level aggregation confidence floor enforcement to ensure all resolution outputs maintain a minimum confidence score of 0.5 as required by audit findings. Added centralized confidence normalization utilities, invariant-safe aggregation handling, and comprehensive unit tests covering low-confidence, invalid, and edge-case scenarios to prevent regressions and preserve protocol integrity.
✅ Added IP resolution utility
Introduced
resolveClientIp()to standardize IP extractionSupports:
x-forwarded-forproxy chainssocket.remoteAddressreq.ipHandles local environments:
127.0.0.1 → local::1 → localFalls back to
"unknown"when missing✅ Updated audit middleware
ipAddressauditContextto request lifecycle✅ Strengthened audit invariants
writeAuditLogipAddressis empty or non-string✅ Added test coverage
IP resolution edge cases:
Audit invariant validation:
🧪 Test Coverage
🔐 Security / Integrity Notes
Low risk
📦 Files Affected
src/utils/ipAddress.tssrc/middleware/auditMiddleware.tssrc/audit/auditLogger.tssrc/utils/ipAddress.test.tssrc/audit/auditLogger.test.ts