Skip to content

Indexer log level spam#252

Open
MaryammAli wants to merge 3 commits into
DigiNodes:mainfrom
MaryammAli:Indexer-log-level-spam
Open

Indexer log level spam#252
MaryammAli wants to merge 3 commits into
DigiNodes:mainfrom
MaryammAli:Indexer-log-level-spam

Conversation

@MaryammAli
Copy link
Copy Markdown

@MaryammAli MaryammAli commented May 29, 2026

Refine Indexer Log Level Spam

Overview

This PR refines indexer logging behavior by reducing unnecessary log noise generated during block processing.

Changes Made

  • Moved "Processed Block" log messages from higher-severity logging to the debug level.
  • Refined indexer logging to reduce spam in normal application output.
  • Added unit tests covering updated logging behavior.
  • Verified functionality against existing protocol invariants to ensure no regressions.

Problem Addressed

During audit review, excessive indexer logging was identified as a source of log spam, making operational monitoring more difficult and increasing unnecessary log verbosity.

This update improves log clarity while preserving debugging visibility when debug logging is enabled.

Acceptance Criteria

  • "Processed Block" logging now uses the debug log level.
  • Logging refinement is fully functional.
  • Unit tests pass successfully.
  • No regressions introduced.
  • Protocol invariants remain intact after verification.

Notes

  • This change only affects logging verbosity and does not modify indexer processing logic.
  • Improves observability and production log readability.

References

  • Internal Ref: BE-206

Labels

  • backend
  • stellar-wave
  • complexity-medium

Fix Indexer Failure on Transfer to Self

Overview

This PR refines indexer transaction handling to properly support self-transfer scenarios where the sender and recipient addresses are identical (from == to).

Changes Made

  • Implemented handling for self-transfer edge cases in the indexer logic.
  • Added safeguards to prevent indexer failures when processing transfers where sender and recipient are the same account.
  • Updated transaction processing flow to correctly handle balance/state updates for self-transfers.
  • Added unit tests covering self-transfer scenarios and related edge cases.
  • Verified implementation against protocol invariants to ensure correctness and stability.

Problem Addressed

An audit identified that the indexer could fail when processing transactions where the transfer source and destination were the same account.

This update ensures the indexer processes these transactions safely and consistently without triggering unexpected failures or invalid state transitions.

Acceptance Criteria

  • Self-transfer (from == to) scenarios are handled correctly.
  • Indexer implementation is fully functional.
  • Unit tests pass successfully.
  • No regressions introduced.
  • Protocol invariants verified and maintained.

Notes

  • This change improves robustness for edge-case transaction handling.
  • Existing transfer processing behavior remains unchanged for standard transactions.

References

  • Internal Ref: BE-210

Labels

  • backend
  • stellar-wave
  • complexity-medium

Closes #206
Closes #210

Indexer log level spam
Indexer failure on Transfer to self
@dDevAhmed
Copy link
Copy Markdown
Contributor

resolve conflicts @MaryammAli

@MaryammAli
Copy link
Copy Markdown
Author

@dDevAhmed
conflict resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexer failure on Transfer to self Indexer log level spam

2 participants