Fix wallet deletion audit issue#245
Merged
dDevAhmed merged 2 commits intoMay 30, 2026
Merged
Conversation
Contributor
|
resolve conflicts @Bug-Hunter-X |
04b6693 to
e8ffb7b
Compare
Author
|
@dDevAhmed done sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #181 Missing Wallet deletion audit. It adds audit logging for wallet unlinking to ensure all wallet deletions are recorded in the audit trail.
closes #181
Objectives
Problem Context
During a recent audit it was discovered that wallet unlinking operations were not being logged, leaving a gap in traceability and security compliance.
Technical Scope
src/identity/identity.service.tsto callAuditTrailService.logwith aWALLET_UNLINKEDaction.WALLET_UNLINKEDtoAuditActionTypeenum insrc/audit/entities/audit-log.entity.ts.src/identity/identity.service.spec.tsto assert the audit log call.Acceptance Criteria
WALLET_UNLINKEDaudit entry with appropriate metadata (wallet ID, user ID, address, description).Verification
npm run lint✅ (existing repo warnings only)npm run typecheck✅npm test -- src/identity/identity.service.spec.ts --runInBand✅npm run build✅Security / Integrity Considerations
References
Labels