v8.26.1 Release - Fix GUI Issues, Enable V2 Transport Tests #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release includes critical test infrastructure updates and cross-platform UI improvements to prepare for the v8.26.1 stable release. ## Version Bump - Updated version from 8.26.0 to 8.26.1 - Updated CLAUDE.md with current development status ## V2 Transport Protocol Testing - Enabled BIP324 V2 P2P transport protocol tests in functional test suite - V2 transport is now fully tested (disabled by default, enable with -v2transport=1) - Removed obsolete RPC implementation planning document - Updated test_runner.py to include V2 transport test variants ## Qt Wallet Theme Fixes Fixed critical cross-platform rendering issues affecting Windows, macOS, and Linux: ### Dark Mode Fixes - Fixed invisible transaction text on Linux due to light backgrounds - Corrected alternating row colors in transaction tables - Removed invalid CSS syntax (\!important) that broke macOS rendering - Improved transaction list visibility with proper dark blue backgrounds ### Light Mode Fixes - Fixed File menu dropdown with dark background making text unreadable - Improved transaction hash label visibility with explicit text colors - Fixed transaction amount colors to properly display green (received) and red (sent) - Removed overly aggressive color overrides that prevented amount color coding ### Development Infrastructure - Added external CSS hot-loading feature for rapid theme development - Feature disabled by default (uncomment in digibyte.cpp to enable) - Allows live CSS reload from ~/.digibyte-dev/css/ with F5 key - QFileSystemWatcher integration for automatic reload on CSS changes All UI changes ensure consistent appearance and readability across Windows, macOS, and Linux platforms for both light and dark themes.
The build was failing on macOS with redefinition errors for le32dec, le32enc, and be32enc functions. These functions are already defined in macOS system headers (sys/endian.h) since macOS SDK 10.12+. Error examples: - error: redefinition of 'le32dec' - error: redefinition of 'le32enc' - error: redefinition of 'be32enc' Solution: - Guard custom endian function definitions with #ifndef __APPLE__ - On macOS, include sys/endian.h to use system-provided functions - On other platforms, use our custom inline implementations This fix allows the project to build cleanly on macOS while maintaining compatibility with other platforms that don't provide these functions in their system headers. Ported from feature/digidollar-v1 branch where this was already fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
I say we leave this open for a few days to get more feedback if there are any other small tweaks or fixes we need to make to v8.26. Seems like recent os updates might needs some tweaks to test runner and other build settings. |
Fixes DigiByte-Core#333 Analysis of translation files revealed that Arabic, Persian, and Chinese translations still contained "Bitcoin" characters instead of "DigiByte". This issue existed in both v8.22.2 and v8.26, not introduced by the Bitcoin v26.2 merge. Research of official DigiByte websites (digibyte.org) confirmed the correct translations to use: Changes: - Arabic (ar): بتكوين → DigiByte (Latin) - 3 instances Official digibyte.org/ar/ keeps brand name in Latin characters - Persian (fa, fa_IR): بیتکوین → دیجی بایت - 13 instances Official digibyte.org/fa/ uses "دیجی بایت" (Diji Bayt) - Chinese (zh, zh_CN, zh-Hans, zh-Hant, zh_TW, cmn): 比特币/比特幣 → 极特币 - 100+ instances Official digibyte.org/zh/ uses "极特币" (jí tè bì) as brand name Total: 9 translation files updated with official DigiByte branding consistent with the official DigiByte website localizations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PROBLEM: - macOS SDK provides le32dec/le32enc/be32enc in sys/endian.h - Different macOS versions (local vs GitHub runner) have inconsistent availability - Previous attempts used conditional compilation which broke on different SDK versions SOLUTION: - Rename functions to scrypt_le32dec/scrypt_le32enc/scrypt_be32enc - These unique names never conflict with system headers - Portable byte-by-byte implementations work on ALL platforms - No dependency on platform-specific headers COMPATIBILITY GUARANTEED: ✅ macOS 14+ (GitHub Actions runner) -no system header conflicts ✅ macOS 10.x-15.x (all local Macs) - no system header conflicts ✅ Linux (all distributions) - portable implementation ✅ Intel & Apple Silicon - byte-order agnostic This bulletproof approach eliminates all platform-specific conditional compilation and works universally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes critical test infrastructure updates and cross-platform
UI improvements to prepare for the v8.26.1 stable release.
Version Bump
Translation Changes
Official digibyte.org/ar/ keeps brand name in Latin characters
Official digibyte.org/fa/ uses "دیجی بایت" (Diji Bayt)
Official digibyte.org/zh/ uses "极特币" (jí tè bì) as brand name
V2 Transport Protocol Testing
Qt Wallet Theme Fixes
Fixed critical cross-platform rendering issues affecting Windows, macOS, and Linux:
Dark Mode Fixes
Light Mode Fixes
Development Infrastructure
All UI changes ensure consistent appearance and readability across
Windows, macOS, and Linux platforms for both light and dark themes.