Bug fix/race condition in get soap action #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the use of `asyncMessageFilters.Reverse()` with a direct backward for-loop iteration to prevent unnecessary array allocations, addressing potential performance issues when processing response message filters.
…gDes#1166 This commit addresses a critical thread-safety issue in the `GetSoapAction` method when parsing the `Content-Type` header on .NET 8 and later. The previous implementation could lead to a race condition where a buffer rented from `ArrayPool<Range>.Shared` was returned more than once. This double-return could cause memory corruption and unpredictable behavior under high concurrent loads. The fix consists of the following changes: - A `try-finally` block is now used to ensure the rented buffer is returned to the pool exactly once, regardless of the execution path. - The loops for parsing the header now `break` as soon as the `soapAction` is found, improving efficiency. - Added boundary checks to prevent potential `IndexOutOfRangeException` when processing malformed headers. Additionally, a new concurrency stress test, `GetSoapAction_IsThreadSafe`, has been added to `SoapCore.Tests`. This test uses `Parallel.For` to execute a high volume of concurrent calls to `GetSoapAction`, verifying that the fix is robust and effectively prevents the race condition. relates to issue DigDes#1166
Collaborator
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1166
This commit addresses a critical thread-safety issue in the
GetSoapActionmethod when parsing the
Content-Typeheader on .NET 8 and later.