Skip to content

Add stories for MUI Surface components#166

Merged
VictoriaBeilsten-Edmands merged 1 commit intomainfrom
vbe/mui-surfaces-stories
May 6, 2026
Merged

Add stories for MUI Surface components#166
VictoriaBeilsten-Edmands merged 1 commit intomainfrom
vbe/mui-surfaces-stories

Conversation

@VictoriaBeilsten-Edmands
Copy link
Copy Markdown
Collaborator

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands commented Apr 30, 2026

Adds stories for MUI components Accordion, Paper, AppBar and Card.

Copy link
Copy Markdown
Collaborator

@NKatti2011 NKatti2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (LGTM)

@NKatti2011 NKatti2011 self-requested a review May 5, 2026 11:38
@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands changed the title Add stories for MUI surface components Add stories for MUI Surface components May 6, 2026
@akademy
Copy link
Copy Markdown
Member

akademy commented May 6, 2026

I haven't reviewed the code properly yet, but not expecting anything wrong, maybe a typo or something - will do that later today.

But a more general point is, I would like a message on the Storybook explaining these components are MUI directly and you should see the MUI website for full documentation. It could be done in the same way our Footer has text on its Storybook page.

Also, I wonder if people will now confuse the MUI's AppBar with our one - maybe an explanation, or reference to the other should be added.

@VictoriaBeilsten-Edmands
Copy link
Copy Markdown
Collaborator Author

I can add a comment in on the pages. Could link each component to documentation (e.g. Button), but might be simplest to add a decorator which add the same message to all MUI stories and links to all MUI documentation.

I'll add something about the AppBar.

@akademy
Copy link
Copy Markdown
Member

akademy commented May 6, 2026

Yeah, there's probably a smart way to do it.

We could do that further down the line though. It doesn't have to be part of the branch.

@akademy
Copy link
Copy Markdown
Member

akademy commented May 6, 2026

Ah, I see you've already done it!

@akademy
Copy link
Copy Markdown
Member

akademy commented May 6, 2026

This is a great piece of work.

(One minor thing is, we've used "MUI_" in a few limited cases already, e.g. src/components/navigation/Breadcrumbs.tsx but I suggest we change those files over to Just use"Mui" )

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands merged commit a04490b into main May 6, 2026
4 checks passed
@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands deleted the vbe/mui-surfaces-stories branch May 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants