Add stories for MUI Surface components#166
Conversation
f609ab4 to
c08d5b6
Compare
c08d5b6 to
cff6962
Compare
|
I haven't reviewed the code properly yet, but not expecting anything wrong, maybe a typo or something - will do that later today. But a more general point is, I would like a message on the Storybook explaining these components are MUI directly and you should see the MUI website for full documentation. It could be done in the same way our Footer has text on its Storybook page. Also, I wonder if people will now confuse the MUI's AppBar with our one - maybe an explanation, or reference to the other should be added. |
|
I can add a comment in on the pages. Could link each component to documentation (e.g. Button), but might be simplest to add a decorator which add the same message to all MUI stories and links to all MUI documentation. I'll add something about the AppBar. |
cff6962 to
216211d
Compare
216211d to
405537e
Compare
|
Yeah, there's probably a smart way to do it. We could do that further down the line though. It doesn't have to be part of the branch. |
|
Ah, I see you've already done it! |
|
This is a great piece of work. (One minor thing is, we've used "MUI_" in a few limited cases already, e.g. src/components/navigation/Breadcrumbs.tsx but I suggest we change those files over to Just use"Mui" ) |
Adds stories for MUI components Accordion, Paper, AppBar and Card.