Do not allow rsync destination to be empty#718
Merged
stephen-riggs merged 4 commits intomainfrom Dec 19, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 42.49% 42.80% +0.30%
==========================================
Files 94 94
Lines 10347 10341 -6
Branches 1346 1345 -1
==========================================
+ Hits 4397 4426 +29
+ Misses 5733 5696 -37
- Partials 217 219 +2 🚀 New features to boost your workflow:
|
d-j-hatton
reviewed
Dec 15, 2025
tieneupin
approved these changes
Dec 16, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Thanks for doing this. Looks good to me, and seems to have worked on all our supported workflows so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rsyncer destination determination was very out-of-date and potentially caused a problem on Krios 3.
This updates the logic and adds some tests.