Restrict Upstream Visit Search to Just Directories#692
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 38.24% 38.23% -0.02%
==========================================
Files 97 97
Lines 11593 11591 -2
Branches 1528 1527 -1
==========================================
- Hits 4434 4432 -2
Misses 6964 6964
Partials 195 195 🚀 New features to boost your workflow:
|
eb1c3d7 to
32c7df4
Compare
stephen-riggs
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live testing has shown that occasionally, there will be files with the same naming pattern as the upstream visit directories we are trying to gather and return.
This PR adds an additional if-block to verify that the search match found is a directory. The associated tests were also updated to verify that only directories are gathered and returned.