Merged
Conversation
…te them from ISPyB database tables
* Linked 'CLEMImageSeries' to 'DataCollectionGroup' and 'GridSquare' * Tried modern type hinting notation in 'CLEMImageSeries' table * Added new columns to 'CLEMImageSeries' to keep track of image search string (for globbing images with) and type of dataset (i.e., atlas or grid square) * Removed 'composite_image' column from 'CLEMImageSeries'
…n_and_merge_results' workflow
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 36.94% 38.24% +1.29%
==========================================
Files 97 97
Lines 11459 11593 +134
Branches 1510 1528 +18
==========================================
+ Hits 4234 4434 +200
+ Misses 7063 6964 -99
- Partials 162 195 +33 🚀 New features to boost your workflow:
|
…of image shape, pixel size, and spatial location on grid
…ctions for the sake of readability
… scaled down information about the grid squares being registered
…reprocess' workflow instead, so that the grid square registration and updating functions just register the values as-is
0b55f57 to
2c1ac4f
Compare
c77516e to
d206593
Compare
d12a674 to
6bb3e69
Compare
stephen-riggs
approved these changes
Nov 6, 2025
Contributor
stephen-riggs
left a comment
There was a problem hiding this comment.
All seems fine, as long as you're happy it works
| pixels_x: Optional[int] = Field(default=None) | ||
| pixels_y: Optional[int] = Field(default=None) | ||
| pixel_size: Optional[float] = Field(default=None) | ||
| units: Optional[str] = Field(default=None) |
Contributor
There was a problem hiding this comment.
Do you need the units in the database? I can't see they are used anywhere
Contributor
Author
There was a problem hiding this comment.
That's a valid point. I included it as a just-in-case, so I'll revisit this in the future if no new workflows end up using this column.
6bb3e69 to
a62941c
Compare
7c7cce2 to
31b26f4
Compare
7917b40 to
72b2b1f
Compare
5c988b1 to
df1f732
Compare
…fey and ISPyB have happened
… is the last dataset to be registered
ba2d1d2 to
3abe4f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic to register incoming CLEM data to both ISPyB and its mirror tables on Murfey.
CLEMImageSeriestable to keep track of image metadata needed for the ISPyB insert