Skip to content

Refactor feedback-callback and update package dependencies#688

Merged
tieneupin merged 25 commits intomainfrom
refactor-feedback-callback
Oct 29, 2025
Merged

Refactor feedback-callback and update package dependencies#688
tieneupin merged 25 commits intomainfrom
refactor-feedback-callback

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Oct 28, 2025

Refactored feedback_callback blocks
Migrated the following logic blocks into their own workflows modules, and added unit tests for them:

  • atlas_update
  • data_collection
  • data_collection_group
  • processing_job

These workflows will potentially be shared between multiple data processing pipelines (SPA, tomo, and potentially CLEM), so suggestions on where to put them would be much appreciated.

Modified feedback_callback entry points to return dictionary instead of boolean
Some feedback callback functions will request for a message requeue, which our current setup doesn't support. By switching the workflows to return a dictionary, we can add a key to control whether the message gets requeued or not.

Updated project package dependencies
Some package dependencies were also updated:

  • Removed the version lock on stomp-py from when 8.1.1 caused us issues
  • Removed the FastAPI version lock from when there were conflicting httpx version dependencies
  • Added graypy as an explicit package dependency, since we use it directly
  • Removed backports.entry_points_selectable now that Python 3.9 has been dropped

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 74.30168% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.94%. Comparing base (443fec9) to head (bbf6956).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   35.77%   36.94%   +1.17%     
==========================================
  Files          92       97       +5     
  Lines       11308    11459     +151     
  Branches     1495     1510      +15     
==========================================
+ Hits         4045     4234     +189     
+ Misses       7130     7063      -67     
- Partials      133      162      +29     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin changed the title Refactor feedback-callback Refactor feedback-callback and update package dependencies Oct 28, 2025
@tieneupin tieneupin force-pushed the refactor-feedback-callback branch from 2137f6c to 8057a5c Compare October 29, 2025 00:18
@tieneupin tieneupin requested review from stephen-riggs and removed request for stephen-riggs October 29, 2025 02:49
@tieneupin tieneupin self-assigned this Oct 29, 2025
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component labels Oct 29, 2025
@tieneupin tieneupin marked this pull request as ready for review October 29, 2025 02:49
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it looks fine to me. As long as you've checked that it ran on the test setup ok then I'm happy for this to go in

@tieneupin tieneupin merged commit f91762e into main Oct 29, 2025
17 checks passed
@tieneupin tieneupin deleted the refactor-feedback-callback branch October 29, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants