Refactor feedback-callback and update package dependencies#688
Merged
Refactor feedback-callback and update package dependencies#688
Conversation
…control message requeueing logic as well
… workflows module
…ll in 'register_data_collection' module; added logs
…ct instead of boolean upon failure
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 35.77% 36.94% +1.17%
==========================================
Files 92 97 +5
Lines 11308 11459 +151
Branches 1495 1510 +15
==========================================
+ Hits 4045 4234 +189
+ Misses 7130 7063 -67
- Partials 133 162 +29 🚀 New features to boost your workflow:
|
…conflicting package dependencies
…points are looked up and loaded correctly
…id_square' and 'register_foil_hole'
…enerate the module-level variables
2137f6c to
8057a5c
Compare
stephen-riggs
approved these changes
Oct 29, 2025
Contributor
stephen-riggs
left a comment
There was a problem hiding this comment.
Thanks for doing this, it looks fine to me. As long as you've checked that it ran on the test setup ok then I'm happy for this to go in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
feedback_callbackblocksMigrated the following logic blocks into their own
workflowsmodules, and added unit tests for them:atlas_updatedata_collectiondata_collection_groupprocessing_jobThese workflows will potentially be shared between multiple data processing pipelines (SPA, tomo, and potentially CLEM), so suggestions on where to put them would be much appreciated.
Modified
feedback_callbackentry points to return dictionary instead of booleanSome feedback callback functions will request for a message requeue, which our current setup doesn't support. By switching the workflows to return a dictionary, we can add a key to control whether the message gets requeued or not.
Updated project package dependencies
Some package dependencies were also updated:
stomp-pyfrom when8.1.1caused us issueshttpxversion dependenciesgraypyas an explicit package dependency, since we use it directlybackports.entry_points_selectablenow that Python 3.9 has been dropped