Use different auth procedures for different endpoints#601
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 31.73% 31.86% +0.13%
==========================================
Files 89 91 +2
Lines 10674 10737 +63
Branches 1420 1425 +5
==========================================
+ Hits 3387 3421 +34
- Misses 7175 7203 +28
- Partials 112 113 +1 🚀 New features to boost your workflow:
|
…purpose and splitting the authentication of instrument and frontend tokens into separate functions; created new annotated ints for type hinting in endpoints receiving requests from frontend and instrument server; updates the other server routers to use the newly created annotated ints
…'file_io_frontend', and 'file_io_shared' due to frontened and instrument accessing the same functions; moved 'process_gain()' into 'file_io_shared' so that it can be called from both with proper validation; updated route manifest and client-side URL lookups to reflect this
…n_control'; updated route manifest and module where it's called
…laced 'test_pypi_proxy' URL with URl constructor as well
…d of homebrew method; split session access validation function for instrument server and frontend into separate functions; instrument validation function was incorrectly calling oauth2 scheme for frontend instead of backend; fixed logic for 'create_access_token' and 'generate_token' for handling authentication using either 'password' or 'cookie'; 'simple_token_validation()' should be using instrument server validation function instead
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…nitialised local variable
…)' instead of 'generate_token()'
…at uses the session as a dependency has to be regenerated every test too
…t carry over from test function into endpoint
tieneupin
force-pushed
the
auth-procedures
branch
from
5b98806 to
ff03dcb
Compare
tieneupin
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eu Pin's summary: