Remove the assumption of a raw directory for processed outputs#600
Merged
stephen-riggs merged 5 commits intomainfrom Jun 2, 2025
Merged
Remove the assumption of a raw directory for processed outputs#600stephen-riggs merged 5 commits intomainfrom
stephen-riggs merged 5 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
+ Coverage 31.77% 31.86% +0.08%
==========================================
Files 90 90
Lines 10700 10686 -14
Branches 1422 1419 -3
==========================================
+ Hits 3400 3405 +5
+ Misses 7187 7168 -19
Partials 113 113 🚀 New features to boost your workflow:
|
tieneupin
approved these changes
Jun 2, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Both the SPA and tomo workflows seem to work fine with the key activated and deactivated. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves one of the doppio-live issues, where we assume a raw directory for SPA.
This instead makes it a configurable option, where the
rawis added to the path ifprocess_multiple_datasetsis True, so that in cases such as eBIC where we send multiple datasets to one location they are still divided up.Also makes the path construction consistent between SPA and tomo, which will need checking.