Allow visit completion to run more asynchronously#543
Merged
d-j-hatton merged 10 commits intomainfrom Mar 31, 2025
Merged
Conversation
…tchers and analysers, and finalisation of all rsyncers. Each of these is given a callback that checks the state of all relevant threads before labelling the multigrid controller as dormant once all threads have shutdown
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 28.97% 29.93% +0.96%
==========================================
Files 80 80
Lines 10309 10907 +598
Branches 1363 1450 +87
==========================================
+ Hits 2987 3265 +278
- Misses 7221 7533 +312
- Partials 101 109 +8 🚀 New features to boost your workflow:
|
Contributor
Author
|
Attempts to resolve #530 |
d-j-hatton
commented
Mar 27, 2025
Contributor
Author
|
Need to check that controller is dormant before deleting session from database |
…omes dormant and make it asynchronous
tieneupin
reviewed
Mar 28, 2025
tieneupin
approved these changes
Mar 28, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Some suggestions, but other than that, no obvious errors! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multigrid controller should now be able to handle most of the process of cleaning up all associated threads. Thread completion requests are performed by setting flags and not explicitly waiting for
joins. Callbacks are then used to notify of thread completion. (RSyncerthreads are slightly more complicated because they have to perform file removal after completing.)On completion of all associated threads the multigrid controller will mark itself as dormant. When new multigrid controllers are added dormant controllers are checked for and removed along with the associated Murfey session data. This could also possibly be triggered when the controller marks itself as dormant for a quicker cleanup?