Add rough CPU memory requirements estimation functionality#722
Open
yousefmoazzam wants to merge 7 commits into
Open
Add rough CPU memory requirements estimation functionality#722yousefmoazzam wants to merge 7 commits into
yousefmoazzam wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IMGDA-865
It's worth noting that at the moment, the command does take a few seconds to run:
Profiling shows that the majority of the time taken is in the YAML file loading and parsing, as part of the
Pipelineobject generation. It's not clear how to go about optimising this as loading is IO bound and parsing is something we offload to an external library, so I have left any attempt to optimise this for later.Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes