-
Notifications
You must be signed in to change notification settings - Fork 1
Import ViSR UI app #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
douglaswinter
wants to merge
38
commits into
main
Choose a base branch
from
import_visr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update node version to fix failing CI
Create a static schema representing a response from a blueapi server using only the count plan. Generate a JSON form to fill in parameters for the count plan.
Create a dropdown menu for selecting a plan, populate using a mocked call to blueapi using mockserviceworker. Edit mocked output assuming that the following have been fixed: - DiamondLightSource/blueapi#1129 - DiamondLightSource/blueapi#1123 - DiamondLightSource/blueapi#1124 And reorder the scanspec schema so that its self-referential components can be detected in a single pass.
Get the button to trigger a plan on blueapi, no feedback yet. Add an instrument session field since that is a requirement for blueapi.
Migrate from yarn to pnpm per Diamond's UI policy
* Add Dockerfile for building and serving web UI with NGINX * Add github action to create and push image on release
Add non-jsonforms plan
Add dummy data view using davidia, insert it into the spectroscopy plan view. The view shows an RGB colour pattern pretending to be a detector output.
This change adds instrument session context and provider, which internally caches and retrieves the state using localStorage. Default instrument session can be passed as prop to the provider.
A workflows route for manually submitting workflows using Relay GraphQL client.
* Remove unused css * Redesign the JsonForms section * Add tests for SearchablePlanList * Add tests for PlanBrowser * Add error boundary and tests to PlanParameters * Group PlanBrowser-related components * Add test CI job * Resolve merge conflicts * Fix CI job name * Invert selectedPlan condition for clarity * Render PlanParameters wrapped in InstrumentSessionProvider in test
Separate IS dropdown from IS query Remove repository from workflows
…ssion_via_graph Populate instrument session via graph
An SSE end point (/api/data/events) tells us when scans start/stop and the data files corresponding to the running scan. When a scan is running, we poll /api/data/map three times for R G and B channels. Co-authored-by: Douglas Winter <douglas.winter@diamond.ac.uk>
Discovered when attempting to integrate with existing app. - Expose render, screen, etc (react testing library helpers) - Centralise vitest version in monorepo root package.json; everywhere else referenced as "vitest": "*" - Update README.md, in particular specifying the need to declare vitest as devDependency in your app. - Simplify tsconfig.json
- uses react dependencies from root - uses @atlas/vitest-conf - still to handle CI jobs
- General CI that runs lint, test, build - A reusuable app publisher called by app-specific wrappers, which run on release but can also be run manually
be13b55 to
6a41cd6
Compare
Now with common Dockerfile and nginx.conf
6a41cd6 to
b46258b
Compare
Gzip compression, logging to stdout/stderr, asset caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.