Fix command buttons in pva transport #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
force-pushed
the
commands
branch
3 times, most recently
from
423b7b7 to
3a18861
Compare
GDYendell
force-pushed
the
pva-command-buttons
branch
from
843fa7f to
be05c5c
Compare
Remove uneeded controller_api fixture from some tests
GDYendell
force-pushed
the
pva-command-buttons
branch
from
be05c5c to
b375663
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 90.82% 90.83%
=======================================
Files 70 70
Lines 2486 2488 +2
=======================================
+ Hits 2258 2260 +2
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
shihab-dls
approved these changes
Dec 18, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Changes and tests look good! Tried it out with example_p4p_ioc as well. Approving!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pva transport expects the value for commands to be a boolean, while the ca transports expects it to be an int.