Skip to content

Conversation

@jul-sm
Copy link
Contributor

@jul-sm jul-sm commented Aug 10, 2023

Changes proposed in this pull request:

  • adapt DIO calibration of the HDAWG
  • replace qcodes with qcodes_loop in library imports

@MiniSean @wvlothuizen

In order for the pull request to be merged, the following conditions must be met:

  • test suite (Github actions) passes
  • all reasonable issues raised by codacy must be resolved
  • a positive review is required

Whenever possible the pull request should

  • follow the PEP8 style guide
  • have tests for the code
  • be well documented and contain comments

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

@jul-sm jul-sm requested review from MiniSean and wvlothuizen August 10, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants