Fixes to quantized sequence and scramble decode

[keptsecret]

No description provided.

[devshgraphicsprogramming]

scalar_type is a misnomer, I'd at least call it storage_scalar_type

[devshgraphicsprogramming]

total misnomer, F is a floating point type, so call it uniform_vec_type or input_type

[devshgraphicsprogramming]

unsigned_scalar_type and uvbec_type are misnomers, I'd call them uniform_storage_scalar_type and uniform_storage_type and also add a comment that explains they're the type which holds the uint bit representation of a unorm thats allowed to have 1s in MSB (normalized w.r.t whole scalar)

[devshgraphicsprogramming]

@keptsecret the HLSL Path Tracer (on the other branch) works with a quantized sequence from the latest commit here, correct?

[AnastaZIuk]

all of those asserts is typo & false trigger

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 127 in cd67d94

store_type get(const uint16_t idx) { assert(idx > 0 && idx < 1); return data; }

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 128 in cd67d94

void set(const uint16_t idx, const store_type value) { assert(idx > 0 && idx < 1); data = value; }

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 176 in cd67d94

assert(idx > 0 && idx < Dim);

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 182 in cd67d94

assert(idx > 0 && idx < Dim);

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 227 in cd67d94

scalar_type get(const uint16_t idx) { assert(idx > 0 && idx < Dim); return data[idx]; }

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Line 228 in cd67d94

void set(const uint16_t idx, const scalar_type value) { assert(idx > 0 && idx < Dim); data[idx] = value; }

since index can be 0

Nabla/include/nbl/builtin/hlsl/sampling/quantized_sequence.hlsl

Lines 165 to 170 in cd67d94

	static this_t create(const vector<store_type, Dimension> value)
	{
	this_t seq;
	seq.data = store_type(0u);
	NBL_UNROLL for (uint16_t i = 0; i < Dimension; i++)
	seq.set(i, value[i]);

should be idx < Dim or idx >= 0 && idx < Dim

[keptsecret]

@keptsecret the HLSL Path Tracer (on the other branch) works with a quantized sequence from the latest commit here, correct?

Yep, last I checked still works