New sampler concepts by karimsayedre · Pull Request #1058 · Devsh-Graphics-Programming/Nabla

Commits on Apr 16, 2026

Commits on Apr 17, 2026

`UsePdfAsWeight==false` implementation was 100% wrong
devshgraphicsprogramming
committed
why its always to use accessing methods than members directly in other code :P
devshgraphicsprogramming
committed
The Spherical Rectangle Shape needs to be created with the observer (local coordinate system) already given and fixed.
devshgraphicsprogramming
committed
Spherical Rectangle needs `generateInverse` implemented, otherwise PRactical Warps are broken wrong weight was getting returned and MIS weights were inconsistent.
devshgraphicsprogramming
committed
Update spherical_triangle.hlsl
devshgraphicsprogramming
authored

Commits on Apr 21, 2026

fixed compartor float vs bool warning, no more spherical triangle boilerplate, addressed comments
karimsayedre
committed

Commits on Apr 24, 2026

Commits on Apr 27, 2026

replaced all sampler literal floats casting with `_static_cast<>()`
karimsayedre
committed

Commits on May 13, 2026

Commits on May 17, 2026

Update examples benchmark sync fix
AnastaZIuk
committed

Commits on May 18, 2026

Commits on May 21, 2026

Merge remote-tracking branch 'origin/tester_improvements' into new-sampler-concepts
karimsayedre
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New sampler concepts#1058

New sampler concepts#1058
karimsayedre wants to merge 22 commits into
masterfrom
new-sampler-concepts

Commits on Apr 16, 2026

factorize out a bunch of stuff, make the Spherical Rectangle Solid Angle Sampler global like its Triangle counterpart, we need to keep the basis around

Updated examples

Updated examples

epic optimization!

Commits on Apr 17, 2026

`UsePdfAsWeight==false` implementation was 100% wrong

why its always to use accessing methods than members directly in other code :P

The Spherical Rectangle Shape needs to be created with the observer (local coordinate system) already given and fixed.

Spherical Rectangle needs `generateInverse` implemented, otherwise PRactical Warps are broken wrong weight was getting returned and MIS weights were inconsistent.

Update spherical_triangle.hlsl

Commits on Apr 21, 2026

fixed compartor float vs bool warning, no more spherical triangle boilerplate, addressed comments

Commits on Apr 24, 2026

Eytzinger CDF, alias table is packed, 2 versions, CDF sampler now has 3 enumed types (tracking, YOLO, Eytzinger)

forgotten to commit file

Merge branch 'master' into new-sampler-concepts

Commits on Apr 27, 2026

replaced all sampler literal floats casting with `_static_cast<>()`

Commits on May 13, 2026

spherical rectangle computeHitT fix and assert fixes

Merge branch 'master' into new-sampler-concepts

Add structured stats/IRs to pipeline executable info

Commits on May 17, 2026

Update examples benchmark sync fix

Commits on May 18, 2026

Harden pipeline executable info

Merge pull request #1070 from Devsh-Graphics-Programming/IBenchmark

Merge branch 'master' into new-sampler-concepts

Commits on May 21, 2026

Merge remote-tracking branch 'origin/tester_improvements' into new-sampler-concepts