Solid angle vis#232
Draft
karimsayedre wants to merge 45 commits into
Draft
Conversation
…id angle", rest should be shader work
…ns for both views, solid angle shader now outputs correct cube vertices correctly
…also added Q and E for moving up and down
- Camera movement is disabled correctly - Hacked ViewManipulate to use for the cube itself - Added a storage buffer for debugging and getting stuff from GPU to CPU - Most importantly, disabled skew, used TRS for that - Random OBB buttons - Detection of mismatch of silhouette vertices (between slow more correct algo vs fast LUT based algo)
- More debug data going to imgui - Little bit of shader code refactoring - "Revert to last" button to go back to last random transformation of the OBB - Added getVertexZNeg() and getVertex() preprocessor branches for faster versions
# Conflicts: # CMakeLists.txt
- Correct manipulation of OBB using `ImGuizmo::ViewManipulate()` - More visualizations of cube faces and 2D Primary Sample Space
…added NSC compile rules (for benchmark only for now)
# Conflicts: # CMakeLists.txt # common/include/nbl/examples/cameras/CCamera.hpp
- Added bilinear and biquadratic samplers - Added a modified version of Urena 2003 with better pre-computation - Fixes after merge from master - Shaders precompiled with permutations for runtime changing of sampling modes without register overhead etc. - removed a lot of code duplications
…sts and benchmarks, example 37 and 64 now use a single command buffer for benchmarks
# Conflicts: # 31_HLSLPathTracer/app_resources/hlsl/next_event_estimator.hlsl
…ramming/Nabla-Examples-and-Tests into solid-angle-vis
… code, less code duplication, faster pyramid creation, and - Way more organized code - Less code duplication - Faster pyramid creation - Faster silhouette creation - Added back the rotating calipers with Lexell version (O(N*(N-2), templated bool)
… (used NTTP instead)
- pipeline layout declares the PC range, output buf is BDA-allocated, PC pushed before the dispatch loop - spherical rectangle: new tests for generateNormalizedLocal / generateUnnormalized / computeHitT, bug in computeHitT - drop redundant pdf field in tests
Refactored the GPU benchmarking system to use new helper classes (`IBenchmark`, `GPUBenchmarkHelper`, and related types), replacing manual pipeline nuffer, and query management with a unified, extensible framework. Benchmarks now use a common `Aggregator` for session orchestration, CLI parsing, baseline comparison, and reporting. Added support for hierarchical variant names, focus/median-of-K runs, robust JSON output, and improved console reporting. Updated main application and all benchmarks to use the new structure, improving maintainability and extensibility.
# Conflicts: # CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.