test(jetsocat): match CI feature flags in testsuite builds#1720
Open
Benoît Cortier (CBenoit) wants to merge 2 commits intomasterfrom
Open
test(jetsocat): match CI feature flags in testsuite builds#1720Benoît Cortier (CBenoit) wants to merge 2 commits intomasterfrom
Benoît Cortier (CBenoit) wants to merge 2 commits intomasterfrom
Conversation
Build jetsocat with native-tls instead of rustls on Windows in the testsuite, matching the CI configuration. Update test expectations to reflect that only the schannel backend runs on Windows. Issue: DGW-350 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rust testsuite so Windows jetsocat builds/execution align with the CI TLS backend choice (native-tls/schannel), and adjusts doctor test expectations accordingly (DGW-350).
Changes:
- Update doctor JSON-output tests to expect only schannel-based diagnostics on Windows.
- Adjust testsuite’s jetsocat build configuration on Windows to disable default features and enable native-tls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
testsuite/tests/cli/jetsocat.rs |
Updates Windows-specific expected failures/warnings to reflect schannel-only diagnostics. |
testsuite/src/cli.rs |
Changes how the testsuite builds jetsocat on Windows to use native-tls instead of rustls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Benoît Cortier (CBenoit)
force-pushed
the
test/match-ci-behavior
branch
from
d127636 to
5538519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build jetsocat with native-tls instead of rustls on Windows in the testsuite, matching the CI configuration. Update test expectations to reflect that only the schannel backend runs on Windows.