build(deps): fix picky 7.0.0-rc.20 incompatibility with sspi #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crates The dependency update from dependabot introduced picky 7.0.0-rc.20, which has breaking API changes incompatible with sspi versions used by IronRDP. Downgraded picky and related crates to their previous versions: - picky: 7.0.0-rc.20 -> 7.0.0-rc.15 - picky-krb: 0.11.3 -> 0.11.0 - picky-asn1-der: 0.5.4 -> 0.5.2 - picky-asn1-x509: 0.14.6 -> 0.14.4 - now-proto-pdu: 0.4.2 -> 0.4.1 - proxy_cfg: 0.4.2 -> 0.4.1 Also ran `cargo update` to update all other dependencies to their latest compatible versions. Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dependencies with patch group bump
build(deps): fix picky 7.0.0-rc.20 incompatibility with sspi
Dec 19, 2025
Member
|
@copilot Are you sure we need to downgrade now-proto-pdu? |
Member
|
@copilot Also keep proxy_cfg to 0.4.2 |
These crates have no dependency on picky or picky-related crates, so their downgrade was unnecessary. Restoring them to 0.4.2 as included in the original dependabot update. Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Contributor
Author
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dependabot update introduced
picky 7.0.0-rc.20, which has breaking API changes incompatible withsspicrate versions used by IronRDP, causing compilation failures in both 0.11.1 and 0.16.1.Changes
pickyfrom7.0.0-rc.20to7.0.0-rc.15indevolutions-gateway/Cargo.tomlpicky-krb: 0.11.3 → 0.11.0picky-asn1-der: 0.5.4 → 0.5.2picky-asn1-x509: 0.14.6 → 0.14.4now-proto-pdu: 0.4.2 (no picky dependency)proxy_cfg: 0.4.2 (no picky dependency)cargo update(161 packages)Technical Details
The
picky-7.0.0-rc.20release changedRsaPublicKey::from_rsa_components()to useBoxedUintinstead ofBigUint, andpicky-krbadded new error variants. These changes brokesspiversions pinned by IronRDP git dependencies used indevolutions-agent.Only picky-related crates needed downgrading. The
now-proto-pduandproxy_cfgupdates are unrelated to the picky issue and were kept at their updated versions (0.4.2) from the Dependabot PR.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.