Normalize productinfo updater versions to 3 components before comparison#4470
Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits intomainfrom Mar 14, 2026
Conversation
Copilot started work on behalf of
Marc-André Moreau (mamoreau-devolutions)
March 14, 2026 04:04
View session
Co-authored-by: mamoreau-devolutions <242016029+mamoreau-devolutions@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update version comparison logic for product info
Normalize productinfo updater versions to 3 components before comparison
Mar 14, 2026
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Mar 14, 2026
Richard Markiewicz (thenextman)
approved these changes
Mar 14, 2026
c2e8590
into
main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The productinfo-based updater was treating
2026.1.0and2026.1.0.0as different versions, which caused repeated prompts to install the already-installed release. This change trims any parsed 4-part productinfo version to its first 3 components before comparing it with the installed version.Updater comparison
System.Versionvalues from the productinfo path before evaluatingavailable > current.2026.1.0.0→2026.1.02026.1.0.5→2026.1.0Normalization helper
Regression coverage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
crl.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/EB23B7D1B15B85081672081E55C17E18/missingpackages_workingdir --packages /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)invalid.url.com/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.Tools.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.Tools.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/testhost.dll --port 32923 --endpoint 127.0.0.1:032923 --role client --parentprocessid 4613 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/testhost.dll --port 37149 --endpoint 127.0.0.1:037149 --role client --parentprocessid 5024 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/testhost.dll --port 44187 --endpoint 127.0.0.1:044187 --role client --parentprocessid 5246 --telemetryoptedin false son(dns block)marticliment.com/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.Tools.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.Tools.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/x64/Debug/net8.0/testhost.dll --port 32923 --endpoint 127.0.0.1:032923 --role client --parentprocessid 4613 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.IconEngine.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.IconEngine.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.IconEngine.Tests/bin/x64/Debug/net8.0/UniGetUI.Core.IconEngine.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.IconEngine.Tests/bin/x64/Debug/net8.0/testhost.dll --port 33247 --endpoint 127.0.0.1:033247 --role client --parentprocessid 4649 --telemetryoptedin false(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/UniGetUI.Core.Tools.Tests.deps.json /home/REDACTED/work/UniGetUI/UniGetUI/src/UniGetUI.Core.Tools.Tests/bin/Debug/net8.0/testhost.dll --port 37149 --endpoint 127.0.0.1:037149 --role client --parentprocessid 5024 --telemetryoptedin false(dns block)ocsp.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/EB23B7D1B15B85081672081E55C17E18/missingpackages_workingdir --packages /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-1c162a69c27bc0ce/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.