Skip to content

Conversation

Copy link

Copilot AI commented Jan 20, 2026

The whoami 2.0 upgrade introduced breaking API changes that caused compilation failures.

Changes

  • Platform enum: Platform::MacOSPlatform::Mac
  • Hostname API: fallible::hostname()hostname() (returns Result directly)
// Before (whoami 1.x)
client_name: whoami::fallible::hostname().unwrap_or_else(|_| "ironrdp".to_owned()),
platform: match whoami::platform() {
    whoami::Platform::MacOS => MajorPlatformType::MACINTOSH,
    // ...
}

// After (whoami 2.0)
client_name: whoami::hostname().unwrap_or_else(|_| "ironrdp".to_owned()),
platform: match whoami::platform() {
    whoami::Platform::Mac => MajorPlatformType::MACINTOSH,
    // ...
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.rs
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https debug-assertions=on --cfg feature=&#34;default&#34; lib/�� lib/rustlib/x86_--error-format=json lib/rustlib/x86_--json=diagnostic-rendered-ansi,artifacts,future-incompat bin/rustc lib/rustlib/x86_/home/REDACTED/.rustup/toolchains/1.88.0-x86_64-REDACTED-linux-gnu/bin/rustc lib/rustlib/x86_--crate-name lib/rustlib/x86_resolv_conf bin/rustc lib/�� lib/rustlib/x86_--error-format=json lib/rustlib/x86_--json=diagnostic-rendered-ansi,artifacts,future-incompat f/idna_adapter-1--crate-type uild/thiserror-0git orted/include py-library known-linux-gnu/--ignore-submodules (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update whoami dependency from 1.6.1 to 2.0.2 Fix whoami 2.0 API compatibility Jan 20, 2026
Copilot AI requested a review from CBenoit January 20, 2026 15:06
@CBenoit CBenoit marked this pull request as ready for review January 20, 2026 15:36
@CBenoit CBenoit merged commit 4edea8f into dependabot/cargo/whoami-2.0.2 Jan 20, 2026
3 checks passed
@CBenoit CBenoit deleted the copilot/sub-pr-1081 branch January 20, 2026 15:36
@github-actions
Copy link

Coverage Report 🤖 ⚙️

Past:
Total lines: 30247
Covered lines: 18808 (62.18%)

New:
Total lines: 30247
Covered lines: 18812 (62.19%)

Diff: +0.01%

[this comment will be updated automatically]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants