[UX] Confirmation Dialog System #256
Conversation
- Replaces `window.confirm` with a custom, accessible `ConfirmDialog` component. - Implements `ConfirmContext` for asynchronous confirmation handling using Promises. - Adds `ConfirmProvider` to `App.tsx` to enable global usage. - Updates `GroupDetails.tsx` to use `useConfirm` for destructive actions (Delete Group, Delete Expense, Leave Group, Remove Member). - Enhances `Modal.tsx` accessibility by adding `role="dialog"`, `aria-modal="true"`, and `aria-labelledby`. - Supports both Neobrutalism and Glassmorphism themes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for split-but-wiser ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This PR introduces a complete Confirmation Dialog system to the Web application, replacing the native and intrusive
window.confirmdialogs with a custom, accessible, and themable UI.Changes:
web/components/ui/ConfirmDialog.tsx- A specialized modal for confirmations with support for 'danger', 'warning', and 'info' variants.web/contexts/ConfirmContext.tsx- Provides auseConfirmhook that returns a Promise, allowing for cleaner async/await usage in components.ConfirmProviderwithinweb/App.tsx.web/pages/GroupDetails.tsxto use the new system for all destructive actions.Modalcomponent to include proper ARIA attributes, ensuring it is correctly identified by screen readers.Verification:
Modalstyles works for both themes.PR created automatically by Jules for task 12669270586709539879 started by @Devasy23