-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(Blog) #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(Blog) #222
Conversation
….org JSON‑LD for Article (BlogPosting) and BreadcrumbList , Added <time datetime> tags where blog dates renders
merging develop
…he BreadcrumbList, logo to the cocial links in User info, Fixed: main container alignment, category navigation in breadcrumbs
…he BreadcrumbList, logo to the cocial links in User info, Fixed: main container alignment, category navigation in breadcrumbs
…, fied breadcrumbs category translaion, added category to the recommended cards, fixed search for localisations
merging develop
merging develop
merging develop
merging develop
feat(Blog): merging develop
✅ Deploy Preview for develop-devlovers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughWraps blog list, category, and post detail pages with Changes
Sequence Diagram(s)(Skipped — changes are layout/components additions and a UI routing sync; they do not introduce a complex multi-component sequential flow that benefits from a diagram.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@frontend/app/`[locale]/blog/category/[category]/page.tsx:
- Around line 157-161: The CTA button rendered by FeaturedPostCtaButton is
invisible to keyboard users because its class sets opacity-0 and only changes on
group-hover; update the className passed to FeaturedPostCtaButton so it also
becomes visible on keyboard focus (for example add a focus-visible:opacity-100
and/or group-focus-within:opacity-100 rule) so tabbing to the control shows the
button and maintains the existing hover behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
frontend/components/blog/BlogFilters.tsx (1)
575-575: Dead code: expression always evaluates to null.
{selectedCategory && null}does nothing — it rendersnullregardless of whetherselectedCategoryis truthy or falsy. This appears to be leftover code that should be removed.🧹 Suggested fix
- {selectedCategory && null}
🤖 Fix all issues with AI agents
In `@frontend/app/`[locale]/blog/page.tsx:
- Around line 27-37: The code treats searchParams synchronously but in Next.js
16+ it's a Promise; update the page component signature to type searchParams as
a Promise (e.g., searchParams?: Promise<{ [key: string]: string | string[] |
undefined }>) and then await it at the top (const sp = await searchParams)
before using it; replace uses of searchParams with the awaited variable (sp)
when computing authorParam and hasAuthorFilter so access is async-safe alongside
the existing await for params and getTranslations.
🧹 Nitpick comments (1)
frontend/components/blog/BlogPageHeader.tsx (1)
10-13: Redundant author-filter check duplicates parent logic.The parent component (
BlogPage) already conditionally rendersBlogPageHeaderonly when!hasAuthorFilter(seepage.tsxlines 89-91). The internalauthorParamcheck here is redundant and creates duplicated logic that could diverge during maintenance.Consider removing the internal check since the parent guarantees this component is only rendered when there's no author filter:
♻️ Suggested simplification
export function BlogPageHeader({ title, subtitle }: BlogPageHeaderProps) { - const searchParams = useSearchParams(); - const authorParam = (searchParams?.get('author') || '').trim(); - if (authorParam) return null; - return ( <> <h1 className="text-5xl font-extrabold mb-3 text-center leading-[1.1] bg-gradient-to-b from-[color-mix(in_srgb,var(--accent-primary)_70%,white)] to-[var(--accent-hover)] bg-clip-text text-transparent">This would also allow removing the
'use client'directive if no other client-side hooks are needed, making this a simpler server component.
Aligning the blog page design with the general concept
Summary by CodeRabbit
New Features
UI Improvements
✏️ Tip: You can customize this high-level summary in your review settings.