Conversation
Contributor
Author
|
로컬에선 되는데, CI 테스트에선 실패. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 요약(Summary)
새로운 리포지토리 테스트들을 추가하여 테스트 커버리지를 17% -> 21%로 늘렸습니다.
이 과정에서, 이전 pr이었던 싱글톤 패턴 때문에 히카리 풀이 늘어날 때마다 idle 커넥션을 10개씩 생성하여 리포지토리 테스트가 10개를 넘어서는 순간 100개 이상의 커넥션이 생성되어 전체 테스트가 터지는 문제가 있었습니다.
이를 Hikari 설정 중 minimum-idle을 0으로 설정하여 필요할 때만 커넥션을 생성하는 Lazy 방식으로 변경했습니다.
📸스크린샷 (선택)
💬 공유사항
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.