Vulnerabilities fixes (Part 2)

[aleks-pro]

1. babel/preset-env updated
2. gulp-eslint replaced with gulp-eslint-new
3. eslint version updated

[Copilot]

Pull request overview

This PR appears to address security/vulnerability concerns primarily by upgrading the project’s linting/tooling dependencies (ESLint, TypeScript, @typescript-eslint/*, gulp-eslint replacement) and then applying mechanical formatting/lint-suppression adjustments across source and test/fixture files so the repo continues to lint/build cleanly.

Changes:

• Upgrade core dev tooling (ESLint → v9, @typescript-eslint/* → v8, TypeScript → 4.9, switch to gulp-eslint-new) and add a new flat eslint.config.js.
• Remove/adjust many inline ESLint suppression comments and apply formatting changes across src and test fixtures to satisfy updated lint rules.
• Update tests/fixtures expectations impacted by formatting/callsite/line-number shifts.

Reviewed changes

Copilot reviewed 60 out of 80 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ts-defs-src/test-api/test-controller.d.ts	Whitespace cleanup in TypeScript definitions.
test/server/util-test.js	Adjust test stub setter behavior.
test/server/parse-fixture-test.js	Update expected structure offsets/locations for TypeScript parsing tests.
test/server/data/test-suites/typescript-testcafe-scripts-defs/test-controller.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-testcafe-scripts-defs/selector.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-testcafe-scripts-defs/roles.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-testcafe-scripts-defs/request-hooks.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-testcafe-scripts-defs/client-function.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-testcafe-scripts-defs/assertions.ts	Formatting/lint-driven edits in TS defs test suite.
test/server/data/test-suites/typescript-test-redeclared-in-types/testfile.ts	Formatting/lint-driven edits in TS test suite.
test/server/data/test-suites/typescript-selectors-defs/selector.ts	Formatting/lint-driven edits in TS selectors defs suite.
test/server/data/test-suites/typescript-selectors-defs/client-function.ts	Formatting/lint-driven edits in TS selectors defs suite.
test/server/data/test-suites/typescript-runner/runner.ts	Formatting/alignment changes in runner TS fixture.
test/server/data/test-suites/typescript-pure-ts-module-dep/testfile.ts	Formatting/lint-driven edits in TS fixture.
test/server/data/test-suites/typescript-parser-smoke/testfile2.ts	Formatting changes affecting parser smoke fixtures.
test/server/data/test-suites/typescript-parser-smoke/testfile1.ts	Formatting changes affecting parser smoke fixtures.
test/server/data/test-suites/typescript-mixed-dep/testfile.ts	Formatting/lint-driven edits in TS fixture.
test/server/data/test-suites/typescript-mixed-dep/dep1.ts	Minor loop variable modernization/formatting in TS fixture dep.
test/server/data/test-suites/typescript-exportable-lib-dep/testfile.ts	Formatting/lint-driven edits in TS fixture.
test/server/data/test-suites/typescript-defs/test-controller.ts	Formatting/lint-driven edits in TS defs fixtures.
test/server/data/test-suites/typescript-defs/structure.ts	Formatting/alignment changes in TS defs structure fixture.
test/server/data/test-suites/typescript-defs/selectors.ts	Formatting/lint-driven edits in TS defs selectors fixture.
test/server/data/test-suites/typescript-defs/roles.ts	Import formatting and spacing changes in TS defs roles fixture.
test/server/data/test-suites/typescript-defs/request-hooks.ts	Import formatting and spacing changes in TS defs request-hooks fixture.
test/server/data/test-suites/typescript-defs/meta.ts	Formatting in TS defs meta fixture.
test/server/data/test-suites/typescript-defs/client-functions.ts	Formatting/lint-driven edits in TS defs client-functions fixture.
test/server/data/test-suites/typescript-defs/assertions.ts	Formatting/lint-driven edits in TS defs assertions fixture.
test/server/data/test-suites/typescript-compile-errors/testfile.ts	Formatting changes in TS compile-errors fixture.
test/server/data/test-suites/typescript-compile-errors/implicitAny.d.ts	Minor formatting/whitespace change in fixture .d.ts.
test/server/data/test-suites/typescript-basic/testfile2.ts	Formatting/var→const changes in TS basic fixtures.
test/server/data/test-suites/typescript-basic/testfile1.ts	Formatting/spacing changes in TS basic fixtures.
test/server/data/test-suites/typescript-basic/dep2.ts	Formatting in TS dep fixture.
test/server/data/test-suites/compile-react/testfile.tsx	JSX/formatting adjustments in TSX fixture.
test/server/configuration-test.js	Remove file-level eslint disable (cleanup).
test/functional/is-touch-device.js	Remove trailing eslint disable (cleanup).
test/functional/fixtures/regression/gh-965/testcafe-fixtures/test-page.js	Reformat test DSL to a single line (affects callsite output).
test/functional/fixtures/regression/gh-965/test.js	Update expected stack trace snippet due to fixture line changes.
test/functional/fixtures/regression/gh-8091/testcafe-fixtures/index.ts	Formatting/semicolon and whitespace cleanup.
test/functional/fixtures/api/typescript/smoke/testcafe-fixtures/non-trivial-test.ts	Import formatting and spacing changes in TS functional fixtures.
test/functional/fixtures/api/typescript/smoke/testcafe-fixtures/callsite-test.ts	Expand one-liner helper and adjust spacing for callsite expectations.
test/functional/fixtures/api/typescript/smoke/test.js	Update expected callsite excerpts due to fixture formatting changes.
test/functional/fixtures/api/es-next/speed/testcafe-fixtures/speed-test.js	Reformat test DSL to single-line .page usage (affects callsites).
test/functional/fixtures/api/es-next/custom-client-scripts/data/with-error.js	var→let tweak in fixture script.
test/functional/fixtures/api/es-next/compiler-options/testcafe-fixtures/typescript/custom-options.ts	Minor formatting cleanup.
test/functional/fixtures/.eslintrc	ESLint rule migration (no-spaced-func → func-call-spacing).
test/client/vendor/async.js	Large mechanical var→const/let refactor in vendor copy (test-side).
src/test-run/index.ts	Remove inline eslint suppression for window usage inside ClientFunction.
src/test-run/commands/validations/argument.js	Refactor URL validation helper for clarity.
src/test-run/commands/options.d.ts	Add missing semicolon in type declaration.
src/reporter/plugin-host.ts	Adjust optional hook implementations and eslint suppression placement.
src/custom-client-scripts/utils.ts	Remove extra-parens suppressions and keep logic intact.
src/custom-client-scripts/problematic-scripts.ts	Remove inline eslint suppression on default export.
src/custom-client-scripts/client-script-init.ts	Remove inline eslint suppression on default export.
src/configuration/types.ts	Switch RequestHook typing to inline type import.
src/client/ui/selector-inspector-panel/utils/ui-root.js	Remove file-level eslint disable (cleanup).
src/client/ui/selector-inspector-panel/utils/set-styles.js	Remove file-level eslint disable (cleanup).
src/client/ui/selector-inspector-panel/tooltip.js	Remove file-level eslint disable (cleanup).
src/client/rollup.config.js	Remove eslint-env node header (cleanup; globals handled elsewhere).
src/client/driver/command-executors/client-functions/types.d.ts	Remove inline eslint suppression comment (cleanup).
src/client/driver/command-executors/client-functions/replicator/transforms/selector-node-transform.ts	Move empty-function suppression to its own line.
src/client/driver/command-executors/client-functions/replicator/transforms/selector-element-action-transform.ts	Move empty-function suppression to its own line.
src/client/driver/command-executors/client-functions/replicator/transforms/client-function-node-transform.ts	Move empty-function suppressions to their own lines.
src/client/driver/barriers/script-execution.ts	Remove inline suppression comment from non-null assertion call.
src/client/driver/barriers/request.ts	Remove inline suppression comment from non-null assertion call.
src/client/core/utils/dom.js	Remove inline suppression comment from hasOwnProperty usage.
src/client/core/scroll/index.ts	Narrow eslint suppression comment to consistent-return only.
src/client/automation/visible-element-automation.ts	Remove inline suppressions, minor formatting cleanup.
src/client/automation/playback/press/utils.js	Replace empty-catch suppression with explicit “intentionally empty” comment.
src/client-functions/selectors/selector-text-filter.js	Remove file-level no-undef disables (cleanup).
src/client-functions/selectors/selector-attribute-filter.js	Remove file-level no-undef disables (cleanup).
src/cli/argument-parser/index.ts	Remove no-extra-parens suppressions (cleanup).
src/browser/provider/utils/client-functions.ts	Remove file-level no-undef/no-var disables (cleanup).
src/assertions/executor.ts	Remove extra-parens suppression (cleanup).
package.json	Upgrade tooling deps (ESLint, TS, typescript-eslint) and swap gulp-eslint → gulp-eslint-new.
Gulpfile.js	Switch lint task to gulp-eslint-new.
eslint.config.js	Add ESLint v9 flat config bridging legacy .eslintrc files via FlatCompat.
.github/scripts/security-checker.mjs	Minor style fixes (semicolons, spacing, const in loops).
.eslintrc	Update/replace deprecated rules and tweak TS-eslint config for new major versions.
.eslintignore	Remove (ignore moved into flat config via ignores).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.