AIIntegration: Update module export to match types (T1324402)#32976
Open
r-farkhutdinov wants to merge 1 commit intoDevExpress:26_1from
Open
AIIntegration: Update module export to match types (T1324402)#32976r-farkhutdinov wants to merge 1 commit intoDevExpress:26_1from
r-farkhutdinov wants to merge 1 commit intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dx.ai-integration bundle’s global export shape so it matches the TypeScript namespace layout (DevExpress.aiIntegration.AIIntegration), and aligns the jQuery demos with the new access path.
Changes:
- Change
dx.ai-integrationbundle template to exposeAIIntegrationunderDevExpress.aiIntegration.AIIntegration. - Update affected jQuery demos to instantiate
DevExpress.aiIntegration.AIIntegrationinstead ofDevExpress.aiIntegration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/build/bundle-templates/dx.ai-integration.js | Adjusts global namespace/export wiring for the AIIntegration bundle. |
| apps/demos/Demos/TreeList/AIColumns/jQuery/index.js | Updates demo to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/HtmlEditor/AITextEditing/jQuery/index.js | Updates demo to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/Form/SmartPaste/jQuery/index.js | Updates demo to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/DataGrid/AIColumns/jQuery/index.js | Updates demo to use DevExpress.aiIntegration.AIIntegration. |
You can also share your feedback on Copilot code review. Take the survey.
r-farkhutdinov
force-pushed
the
26_1_T1324402
branch
from
35ac9ea to
f86a00e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the DevExpress.aiIntegration runtime export shape with the expected typings by exposing AIIntegration under a namespace-like object, and updates tests/demos to use the new access path.
Changes:
- Update the dx.ai-integration bundle template to export
DevExpress.aiIntegration.AIIntegration. - Update e2e TestCafe tests to instantiate
DevExpress.aiIntegration.AIIntegration. - Update jQuery demos to instantiate
DevExpress.aiIntegration.AIIntegration.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/build/bundle-templates/dx.ai-integration.js | Changes global/module export shape to expose AIIntegration on DevExpress.aiIntegration. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/virtualScrolling.functional.ts | Updates DataGrid e2e instantiation path to aiIntegration.AIIntegration. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/functional.ts | Updates DataGrid e2e instantiation path to aiIntegration.AIIntegration across scenarios. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiColumn/adaptivity.functional.ts | Updates DataGrid adaptivity e2e instantiation path to aiIntegration.AIIntegration. |
| e2e/testcafe-devextreme/tests/common/treeList/aiColumn/functional.ts | Updates TreeList e2e instantiation path to aiIntegration.AIIntegration. |
| apps/demos/Demos/TreeList/AIColumns/jQuery/index.js | Updates demo code to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/HtmlEditor/AITextEditing/jQuery/index.js | Updates demo code to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/Form/SmartPaste/jQuery/index.js | Updates demo code to use DevExpress.aiIntegration.AIIntegration. |
| apps/demos/Demos/DataGrid/AIColumns/jQuery/index.js | Updates demo code to use DevExpress.aiIntegration.AIIntegration. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+5
to
+6
| DevExpress.aiIntegration = {}; | ||
| module.exports = DevExpress.aiIntegration.AIIntegration = AIIntegration; |
| @@ -93,7 +93,7 @@ test('Get result from AI and display it in the AI column', async (t) => { | |||
| ai: { | |||
| prompt: 'first AI column', | |||
| // eslint-disable-next-line new-cap | |||
|
|
||
| module.exports = DevExpress.aiIntegration = AIIntegration; | ||
| DevExpress.aiIntegration = {}; | ||
| module.exports = DevExpress.aiIntegration.AIIntegration = AIIntegration; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.