DataGrid - Fix lookup filter changing to "(All)" after searching twice in another column (T1284002)#32969
Open
markallenramirez wants to merge 3 commits intoDevExpress:26_1from
Open
DataGrid - Fix lookup filter changing to "(All)" after searching twice in another column (T1284002)#32969markallenramirez wants to merge 3 commits intoDevExpress:26_1from
markallenramirez wants to merge 3 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end regression test to ensure DataGrid filter row lookup selections are preserved when the user types into another column’s filter editor multiple times (T1284002).
Changes:
- Added
SelectBoxusage in the filter row functional TestCafe suite. - Added a new TestCafe test that selects a lookup filter value, types into a text filter twice, and asserts the lookup filter remains unchanged.
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
| || !equalByValue(editorDataSource.__dataGridSourceFilter || null, filter); | ||
|
|
||
| if (shouldUpdateFilter) { | ||
| const selectedItem = editor.option('selectedItem'); |
Contributor
There was a problem hiding this comment.
minor: it is preferable to use destructurization from options() instead of getting option by name
in that case it will not lose types if editor properly typed
const { selectedItem, items = [] } = editor.option();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.